Build failures on Windows with 5.7-lkgr

[targos]

CI run: https://ci.nodejs.org/job/node-compile-windows/7129/

Errors:

     Creating library c:\workspace\node-compile-windows\label\win-vs2015\Release\mksnapshot.lib and object c:\workspace\node-compile-windows\label\win-vs2015\Release\mksnapshot.exp
v8_base_1.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForId(enum v8::internal::Runtime::FunctionId)" (?FunctionForId@Runtime@internal@v8@@SAPEBUFunction@123@W4FunctionId@123@@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
v8_base_1.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForName(unsigned char const *,int)" (?FunctionForName@Runtime@internal@v8@@SAPEBUFunction@123@PEBEH@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::RuntimeFunctionTable(class v8::internal::Isolate *)" (?RuntimeFunctionTable@Runtime@internal@v8@@SAPEBUFunction@123@PEAVIsolate@23@@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForEntry(unsigned char *)" (?FunctionForEntry@Runtime@internal@v8@@SAPEBUFunction@123@PEAE@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
v8_base_0.lib(js-operator.obj) : error LNK2001: unresolved external symbol "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl v8::internal::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,enum v8::internal::Runtime::FunctionId)" (??6internal@v8@@YAAEAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AEAV23@W4FunctionId@Runtime@01@@Z) [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]
c:\workspace\node-compile-windows\label\win-vs2015\Release\mksnapshot.exe : fatal error LNK1120: 5 unresolved externals [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\mksnapshot.vcxproj]

/cc @nodejs/v8

[targos]

Confirmed in a new run: https://ci.nodejs.org/job/node-compile-windows/7432/
/cc @nodejs/platform-windows

[targos]

@joaocgreis FYI this issue is fixed in V8 master. I don't know what commit fixed it.

[targos]

The error disappears with this commit: v8@3297130.

[targos]

Confirmed: https://ci.nodejs.org/job/node-test-commit/8640/

[joaocgreis]

This was fixed for x64, but possibly never tested on x86. Now, x86 builds are failing (nodejs/build#669), the V8 update seems to be the root cause (still unconfirmed but the timing matches). The console output is similar:

     Creating library c:\ws\Release\mksnapshot.lib and object c:\ws\Release\mksnapshot.exp
v8_base_0.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForId(enum v8::internal::Runtime::FunctionId)" (?FunctionForId@Runtime@internal@v8@@SAPBUFunction@123@W4FunctionId@123@@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_0.lib(parser.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForName(unsigned char const *,int)" (?FunctionForName@Runtime@internal@v8@@SAPBUFunction@123@PBEH@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::RuntimeFunctionTable(class v8::internal::Isolate *)" (?RuntimeFunctionTable@Runtime@internal@v8@@SAPBUFunction@123@PAVIsolate@23@@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_3.lib(assembler.obj) : error LNK2001: unresolved external symbol "public: static struct v8::internal::Runtime::Function const * __cdecl v8::internal::Runtime::FunctionForEntry(unsigned char *)" (?FunctionForEntry@Runtime@internal@v8@@SAPBUFunction@123@PAE@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
v8_base_0.lib(js-operator.obj) : error LNK2001: unresolved external symbol "class std::basic_ostream<char,struct std::char_traits<char> > & __cdecl v8::internal::operator<<(class std::basic_ostream<char,struct std::char_traits<char> > &,enum v8::internal::Runtime::FunctionId)" (??6internal@v8@@YAAAV?$basic_ostream@DU?$char_traits@D@std@@@std@@AAV23@W4FunctionId@Runtime@01@@Z) [c:\ws\deps\v8\src\mksnapshot.vcxproj]
c:\ws\Release\mksnapshot.exe : fatal error LNK1120: 5 unresolved externals [c:\ws\deps\v8\src\mksnapshot.vcxproj]

[joaocgreis]

The same commit that fixes this for x64 breaks for x86. I was able to confirm that this is because the change of position in v8.gyp, moving those 3 lines to the old position fixes this issue for x86.

[jaimecbernardo]

A fix for this issue landed on V8 upstream.
Original PR: nodejs/node#13959
V8's Code Review: https://chromium-review.googlesource.com/c/556599/
V8's Commit: https://chromium.googlesource.com/v8/v8/+/3bef2af6ef198b0cd1342680bf5d7d782dc71a46