Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove vestigial commitizen references #7317

Merged
merged 1 commit into from
Dec 9, 2024
Merged

chore: remove vestigial commitizen references #7317

merged 1 commit into from
Dec 9, 2024

Conversation

bmuenzenmeyer
Copy link
Collaborator

Description

Fully cleans up what was left after we forcibly removed commitzen within 0c3643f

Validation

no changes expected

Related Issues

#6900
#6844

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@Copilot Copilot bot review requested due to automatic review settings December 7, 2024 03:13
@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner December 7, 2024 03:13
Copy link

vercel bot commented Dec 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Dec 7, 2024 3:13am

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 4 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • package.json: Language not supported
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@canerakdas canerakdas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.79% (631/695) 72.44% (184/254) 94.53% (121/128)

Unit Test Report

Tests Skipped Failures Errors Time
143 0 💤 0 ❌ 0 🔥 4.969s ⏱️

@mikeesto mikeesto added this pull request to the merge queue Dec 9, 2024
Merged via the queue into main with commit 14737ec Dec 9, 2024
16 checks passed
@mikeesto mikeesto deleted the remove-cz branch December 9, 2024 01:13
avivkeller pushed a commit to avivkeller/nodejs.org that referenced this pull request Jan 10, 2025
avivkeller pushed a commit to avivkeller/nodejs.org that referenced this pull request Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants