Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Links for changelog and blog post do not meet accessibility criterion #7250

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

TenzDelek
Copy link
Contributor

Description

fixes the accessibility

Validation

Screenshot 2024-11-20 155628

Related Issues

Fixes #7246

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@TenzDelek TenzDelek requested a review from a team as a code owner November 20, 2024 10:33
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Nov 20, 2024 10:35am

Copy link
Contributor

@wojtekmaj wojtekmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's worth noting that other translations would also need to get updated, but it's a great improvement for many people nonetheless.

@AugustinMauroy
Copy link
Member

It's worth noting that other translations would also need to get updated, but it's a great improvement for many people nonetheless.

Do not touch to translation it's handle by Crowdin

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

Copy link
Contributor

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.73% (627/691) 72.44% (184/254) 94.48% (120/127)

Unit Test Report

Tests Skipped Failures Errors Time
137 0 💤 0 ❌ 0 🔥 5.411s ⏱️

@avivkeller avivkeller added this pull request to the merge queue Nov 20, 2024
Merged via the queue into nodejs:main with commit 8e05ee8 Nov 20, 2024
14 of 15 checks passed
bmuenzenmeyer pushed a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links for changelog and blog post do not meet accessibility criterion
4 participants