-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ES6 docs for v5.0.0 #268
Conversation
@@ -55,12 +55,26 @@ All ES6 features are split into three groups for **shipping**, **staged**, and * | |||
|
|||
* [Arrow Functions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions) | |||
|
|||
* [new.target](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target) | |||
|
|||
* [Object.observe](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/observe) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Object.observe is not in ES6 (there is no standard for it so far) and Node 4 contains it as well. I don't think it belongs on this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree @mzgol
@evanlucas this should go to ES2016 (Is there a list of ES2015/ES2016 that v8 supports? This could be in sync with that list)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps ES.Next or sth to that effect would be better; it's not final yet whether Object.observe
will make it into 2016 AFAIK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch. While I agree it shouldn't be in the ES6 section, I do think it should be mentioned (somewhere). I'll remove it from here though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Object.observe
is dead: https://mail.mozilla.org/pipermail/es-discuss/2015-November/044684.html
With node v5.0.0 will come an updated v8 that includes additional ES6 features. This adds some of those additional features to the ES6 doc
Ok, updated. PTAL |
Looks good now. :) |
Ooh, looking forward to getting these features natively :) |
@@ -55,12 +55,24 @@ All ES6 features are split into three groups for **shipping**, **staged**, and * | |||
|
|||
* [Arrow Functions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions) | |||
|
|||
* [new.target](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target) | |||
|
|||
* [Object.assign](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already in Node 4 BTW.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, I don't think this document was updated then.
Should we change this title to |
@evanlucas You are right … everybody still calls it ES6 for short. ;) What wording does v8 use? Just had a quick look but couldn't find anything. How about "ECMAScript 2015 (ES6)" (taken from MDN)? |
@fhemberger V8 team uses exactly what you are suggesting: http://v8project.blogspot.ch/ |
Ok, I'm adding it to the commit and merge it into the v5.0.0 release branch |
Merged to |
How could these v5 features be marked exclusively for v5? As the site now hosts both v4 and v5, this ES2015 features page also has to take that into consideration. |
@phillipj Just add a second footnote "Only available in Node.js >= 5.x.x" |
With node v5.0.0 will come an updated v8 that includes additional ES6
features. This adds some of those additional features to the ES6 doc
This should not be merged until v5.0.0 is released