Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ES6 docs for v5.0.0 #268

Closed
wants to merge 1 commit into from
Closed

Update ES6 docs for v5.0.0 #268

wants to merge 1 commit into from

Conversation

evanlucas
Copy link
Contributor

With node v5.0.0 will come an updated v8 that includes additional ES6
features. This adds some of those additional features to the ES6 doc

This should not be merged until v5.0.0 is released

@fhemberger fhemberger added this to the 5.0.0 milestone Oct 21, 2015
@@ -55,12 +55,26 @@ All ES6 features are split into three groups for **shipping**, **staged**, and *

* [Arrow Functions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions)

* [new.target](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target)

* [Object.observe](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/observe)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Object.observe is not in ES6 (there is no standard for it so far) and Node 4 contains it as well. I don't think it belongs on this list.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree @mzgol

@evanlucas this should go to ES2016 (Is there a list of ES2015/ES2016 that v8 supports? This could be in sync with that list)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps ES.Next or sth to that effect would be better; it's not final yet whether Object.observe will make it into 2016 AFAIK.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah good catch. While I agree it shouldn't be in the ES6 section, I do think it should be mentioned (somewhere). I'll remove it from here though

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With node v5.0.0 will come an updated v8 that includes additional ES6
features. This adds some of those additional features to the ES6 doc
@evanlucas
Copy link
Contributor Author

Ok, updated. PTAL

@mgol
Copy link

mgol commented Oct 27, 2015

Looks good now. :)

@phillipj
Copy link
Member

Ooh, looking forward to getting these features natively :)

@@ -55,12 +55,24 @@ All ES6 features are split into three groups for **shipping**, **staged**, and *

* [Arrow Functions](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Functions/Arrow_functions)

* [new.target](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/new.target)

* [Object.assign](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already in Node 4 BTW.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I don't think this document was updated then.

@evanlucas
Copy link
Contributor Author

Should we change this title to ES 2015 since that is what the official spec is now?

@fhemberger fhemberger mentioned this pull request Oct 29, 2015
@fhemberger
Copy link
Contributor

@evanlucas You are right … everybody still calls it ES6 for short. ;) What wording does v8 use? Just had a quick look but couldn't find anything. How about "ECMAScript 2015 (ES6)" (taken from MDN)?

@targos
Copy link
Member

targos commented Oct 29, 2015

@fhemberger V8 team uses exactly what you are suggesting: http://v8project.blogspot.ch/

@fhemberger
Copy link
Contributor

Ok, I'm adding it to the commit and merge it into the v5.0.0 release branch

@fhemberger
Copy link
Contributor

Merged to v5.0.0: 8564c4f, waiting for release.

@fhemberger fhemberger closed this Oct 29, 2015
@phillipj
Copy link
Member

How could these v5 features be marked exclusively for v5? As the site now hosts both v4 and v5, this ES2015 features page also has to take that into consideration.

@fhemberger
Copy link
Contributor

@phillipj Just add a second footnote "Only available in Node.js >= 5.x.x"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants