debugger: don't override module binding
#572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Overriding `module` argument with `const` causes `SyntaxError`.
| @@ -4,8 +4,8 @@ const util = require('util'); | |||
| const path = require('path'); | |||
| const net = require('net'); | |||
| const vm = require('vm'); | |||
| const module = require('module'); | |||
| const repl = module.requireRepl(); | |||
| const Module = require('module'); | |||
There was a problem hiding this comment.
@bnoordhuis are you OK with the capitalization? If not, we could replace the two following instances with require('module'), use a different name, or switch from const. Any preference?
There was a problem hiding this comment.
Module is a constructor so it makes sense. It's exactly how it's called in lib/module.js
There was a problem hiding this comment.
@vkurchatkin you're right. It's used that way in other places too.
|
LGTM |
|
And this worked with var? That's interesting... |
cjihrig
pushed a commit
that referenced
this pull request
Jan 23, 2015
Overriding module argument with const causes a SyntaxError. This commit changes the variable name to remove the error. PR-URL: #572 Reviewed-By: Colin Ihrig <[email protected]>
|
Thanks @vkurchatkin! Landed in f4c536b |
|
@Fishrock123 yea, I believe the problem is that a |
|
@Fishrock123 this same with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overriding
moduleargument withconstcausesSyntaxError.Apparently this is something you can't do:
P.S.
make test-debuggerhangs, someone has to look at itR=@cjihrig