process: remove support for undocumented symbol #56552
Open
+6
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
added
backport-requested-v22.x
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56552 +/- ##
==========================================
+ Coverage 89.16% 89.17% +0.01%
==========================================
Files 662 662
Lines 191751 191753 +2
Branches 36900 36904 +4
==========================================
+ Hits 170972 171000 +28
+ Misses 13635 13630 -5
+ Partials 7144 7123 -21
|
lpinca
approved these changes
Jan 10, 2025
jasnell
approved these changes
Jan 10, 2025
I'm confused by this. Why break 22 but not 23? (Why would we break 22 at all?) |
|
What I'm suggesting is we backport all three PRs, so what gets released on 22.x is the correct symbols with documentation, and not the undocumented ones. As Luigi said, it would not break 22.x users since nothing has landed for them atm. |
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Jan 11, 2025
aduh95
added
the
commit-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The symbol was undocumented in #56517, but left in the code to avoid a breaking change. This PR makes the breaking change, I suggest we skip landing it on 23.x and directly backport it to 22.x so that release line only receive support for the documented symbol.