New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set several tests as flaky #54802

Closed

anonrig wants to merge 16 commits into nodejs:main from anonrig:set-flaky-tests-2024

Member

anonrig commented Sep 6, 2024 •

edited

Loading

Sets several tests (16) as flaky


          test: set test-debugger-heap-profiler as flaky

1316c1b

nodejs-github-bot added needs-ci test labels

anonrig requested review from jasnell, mcollina, targos and richardlau

September 6, 2024 15:02

This was referenced Sep 6, 2024

test: mark test-esm-loader-hooks-inspect-wait as flaky #54806

Closed

test: mark test-inspector-connect-to-main-thread as flaky #54805

Closed

jasnell approved these changes

View reviewed changes

anonrig added the commit-queue-rebase label

richardlau reviewed

View reviewed changes

test/parallel/parallel.status Outdated Show resolved Hide resolved

lpinca reviewed

View reviewed changes

test/parallel/parallel.status Outdated Show resolved Hide resolved

anonrig force-pushed the set-flaky-tests-2024 branch from 1e25402 to 778d91a Compare

September 6, 2024 15:16

lpinca reviewed

View reviewed changes

test/async-hooks/async-hooks.status Show resolved Hide resolved

KhafraDev approved these changes

View reviewed changes

jasnell reviewed

View reviewed changes

test/parallel/parallel.status Outdated Show resolved Hide resolved

avivkeller reviewed

View reviewed changes

test/parallel/test-module-loading-globalpaths.js Outdated Show resolved Hide resolved

anonrig force-pushed the set-flaky-tests-2024 branch from 41836e2 to 70d3abc Compare

September 6, 2024 15:43

anonrig added 10 commits

September 6, 2024 11:48


          test: set test-performance-function as flaky

3d3c622


          test: set test-runner-watch-mode-complex as flaky

50fb7a0


          test: set test-http2-large-file as flaky

676f340


          test: set test-esm-loader-hooks-inspect-wait as flaky

d73f062


          test: set test-async-context-frame as flaky

c780fa0


          test: set test-writewrap as flaky

9a4e309


          test: set test-sqlite-statement-sync as flaky

e43cf23


          test: set test-runner-run-watch as flaky

443c244


          test: set test-fs-utimes as flaky

ce984b1


          test: set test-macos-app-sandbox as flaky

b17ef12

anonrig force-pushed the set-flaky-tests-2024 branch from 70d3abc to b17ef12 Compare

September 6, 2024 15:48

aduh95 pushed a commit to aduh95/node that referenced this pull request


          test: move test-worker-arraybuffer-zerofill to parallel

4e176ed

Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54839
Refs: nodejs#54802
PR-URL: nodejs#56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>

aduh95 pushed a commit to aduh95/node that referenced this pull request


          test: move test-worker-arraybuffer-zerofill to parallel

Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54839
Refs: nodejs#54802
PR-URL: nodejs#56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>

aduh95 pushed a commit to aduh95/node that referenced this pull request


          test: move test-worker-arraybuffer-zerofill to parallel

de42550

Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: nodejs#54918
Refs: nodejs#54839
Refs: nodejs#54802
PR-URL: nodejs#56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>

nodejs-github-bot pushed a commit that referenced this pull request


          test: remove test-fs-utimes flaky designation

7904bc0

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <[email protected]>

targos pushed a commit that referenced this pull request


          test: remove test-fs-utimes flaky designation

5edb8d5

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: move test-worker-arraybuffer-zerofill to parallel

eb768df

Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802
PR-URL: #56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: remove test-fs-utimes flaky designation

1700ec3

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: move test-worker-arraybuffer-zerofill to parallel

dd3eb2d

Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802
PR-URL: #56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: remove test-fs-utimes flaky designation

c28a891

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: move test-worker-arraybuffer-zerofill to parallel

Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802
PR-URL: #56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: remove test-fs-utimes flaky designation

30ccb3f

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <[email protected]>

nodejs-github-bot pushed a commit that referenced this pull request


          test: remove test-sqlite-statement-sync flaky designation

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54802
PR-URL: #56051
Reviewed-By: Michaël Zasso <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: move test-worker-arraybuffer-zerofill to parallel

f4615da

Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802
PR-URL: #56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: remove test-fs-utimes flaky designation

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: remove test-sqlite-statement-sync flaky designation

62b2f79

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54802
PR-URL: #56051
Reviewed-By: Michaël Zasso <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: remove test-sqlite-statement-sync flaky designation

3298ef4

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54802
PR-URL: #56051
Reviewed-By: Michaël Zasso <[email protected]>

nodejs-github-bot pushed a commit that referenced this pull request


          test: remove async-hooks/test-writewrap flaky designation

14803ea

The issue is the same as other tests that time out.

Refs: #54918
Refs: #54802
PR-URL: #56048
Reviewed-By: Gerhard Stöbich <[email protected]>

ruyadorno pushed a commit that referenced this pull request


          test: remove test-sqlite-statement-sync flaky designation

570fe14

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54802
PR-URL: #56051
Reviewed-By: Michaël Zasso <[email protected]>

ruyadorno pushed a commit that referenced this pull request


          test: remove test-sqlite-statement-sync flaky designation

3fec5e3

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54802
PR-URL: #56051
Reviewed-By: Michaël Zasso <[email protected]>

aduh95 pushed a commit that referenced this pull request


          test: remove async-hooks/test-writewrap flaky designation

The issue is the same as other tests that time out.

Refs: #54918
Refs: #54802
PR-URL: #56048
Reviewed-By: Gerhard Stöbich <[email protected]>

ruyadorno pushed a commit that referenced this pull request


          test: move test-worker-arraybuffer-zerofill to parallel

211f058

Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.

The original issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54839
Refs: #54802
PR-URL: #56053
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>

ruyadorno pushed a commit that referenced this pull request


          test: remove test-fs-utimes flaky designation

ad107ca

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54844
Refs: #54802
PR-URL: #56052
Reviewed-By: Michaël Zasso <[email protected]>

ruyadorno pushed a commit that referenced this pull request


          test: remove test-sqlite-statement-sync flaky designation

eef9bd1

The issue is likely the same as other tests that time out.

Refs: #54918
Refs: #54802
PR-URL: #56051
Reviewed-By: Michaël Zasso <[email protected]>

lpinca added a commit to lpinca/node that referenced this pull request


          test: use spawnSyncAndExitWithoutError()

3871b83

Use `spawnSyncAndExitWithoutError()` in
`test/parallel/test-macos-app-sandbox.js`.

Refs: nodejs#54802 (comment)

lpinca mentioned this pull request

test: use spawnSyncAndExit{,WithoutError}() #56529

Closed

lpinca added a commit to lpinca/node that referenced this pull request


          test: use spawnSyncAndExitWithoutError()

01e4d77

Use `spawnSyncAndExitWithoutError()` in
`test/parallel/test-macos-app-sandbox.js`.

Refs: nodejs#54802 (comment)

lpinca added a commit to lpinca/node that referenced this pull request


          test: use spawnSyncAndExitWithoutError()

a51c3a0

Use `spawnSyncAndExitWithoutError()` in
`test/parallel/test-macos-app-sandbox.js`.

Refs: nodejs#54802 (comment)

lpinca added a commit to lpinca/node that referenced this pull request


          test: use spawnSyncAndExitWithoutError()

396e17c

Use `spawnSyncAndExitWithoutError()` in
`test/parallel/test-macos-app-sandbox.js`.

Refs: nodejs#54802 (comment)

lpinca added a commit to lpinca/node that referenced this pull request


          test: use spawnSyncAndExitWithoutError()

c57b24a

Use `spawnSyncAndExitWithoutError()` in
`test/parallel/test-macos-app-sandbox.js`.

Refs: nodejs#54802 (comment)

lpinca added a commit to lpinca/node that referenced this pull request


          test: use spawnSyncAndExit{,WithoutError}()

b6a59dd

Use `spawnSyncAndExit()` and `spawnSyncAndExitWithoutError()` in
`test/parallel/test-macos-app-sandbox.js`.

Refs: nodejs#54802 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

avivkeller avivkeller left review comments

jasnell jasnell approved these changes

KhafraDev KhafraDev approved these changes

mhdawson mhdawson approved these changes

mcollina Awaiting requested review from mcollina

targos Awaiting requested review from targos

aduh95 Awaiting requested review from aduh95

richardlau Awaiting requested review from richardlau

lpinca Awaiting requested review from lpinca

Labels

commit-queue-rebase dont-land-on-v20.x fast-track needs-ci test