-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: automate uvwasi dependency update #47509
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
Ranieri93:feat/automate-uvwasi-update
Apr 13, 2023
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
#!/bin/sh | ||
set -e | ||
# Shell script to update uvwasi in the source tree to a specific version | ||
|
||
BASE_DIR=$(cd "$(dirname "$0")/../.." && pwd) | ||
DEPS_DIR="$BASE_DIR/deps" | ||
|
||
[ -z "$NODE" ] && NODE="$BASE_DIR/out/Release/node" | ||
[ -x "$NODE" ] || NODE=$(command -v node) | ||
|
||
NEW_VERSION="$("$NODE" --input-type=module <<'EOF' | ||
const res = await fetch('https://api.github.com/repos/nodejs/uvwasi/releases/latest'); | ||
if (!res.ok) throw new Error(`FetchError: ${res.status} ${res.statusText}`, { cause: res }); | ||
const { tag_name } = await res.json(); | ||
console.log(tag_name.replace('v', '')); | ||
EOF | ||
)" | ||
|
||
CURRENT_MAJOR_VERSION=$(grep "#define UVWASI_VERSION_MAJOR" "$DEPS_DIR/uvwasi/include/uvwasi.h" | sed -n "s/^.*MAJOR \(.*\)/\1/p") | ||
CURRENT_MINOR_VERSION=$(grep "#define UVWASI_VERSION_MINOR" "$DEPS_DIR/uvwasi/include/uvwasi.h" | sed -n "s/^.*MINOR \(.*\)/\1/p") | ||
CURRENT_PATCH_VERSION=$(grep "#define UVWASI_VERSION_PATCH" "$DEPS_DIR/uvwasi/include/uvwasi.h" | sed -n "s/^.*PATCH \(.*\)/\1/p") | ||
CURRENT_VERSION="$CURRENT_MAJOR_VERSION.$CURRENT_MINOR_VERSION.$CURRENT_PATCH_VERSION" | ||
|
||
echo "Comparing $NEW_VERSION with $CURRENT_VERSION" | ||
|
||
if [ "$NEW_VERSION" = "$CURRENT_VERSION" ]; then | ||
echo "Skipped because uvwasi is on the latest version." | ||
exit 0 | ||
fi | ||
|
||
echo "Making temporary workspace" | ||
|
||
WORKSPACE=$(mktemp -d 2> /dev/null || mktemp -d -t 'tmp') | ||
echo "$WORKSPACE" | ||
cleanup () { | ||
EXIT_CODE=$? | ||
[ -d "$WORKSPACE" ] && rm -rf "$WORKSPACE" | ||
exit $EXIT_CODE | ||
} | ||
|
||
trap cleanup INT TERM EXIT | ||
|
||
UVWASI_ZIP="uvwasi-$NEW_VERSION" | ||
cd "$WORKSPACE" | ||
|
||
echo "Fetching UVWASI source archive..." | ||
curl -sL -o "$UVWASI_ZIP.zip" "https://github.com/nodejs/uvwasi/archive/refs/tags/v$NEW_VERSION.zip" | ||
|
||
echo "Moving existing GYP build file" | ||
mv "$DEPS_DIR/uvwasi/"*.gyp "$WORKSPACE/" | ||
rm -rf "$DEPS_DIR/uvwasi/" | ||
|
||
echo "Unzipping..." | ||
unzip "$UVWASI_ZIP.zip" -d "$DEPS_DIR/uvwasi/" | ||
rm "$UVWASI_ZIP.zip" | ||
|
||
mv "$WORKSPACE/"*.gyp "$DEPS_DIR/uvwasi/" | ||
cd "$DEPS_DIR/uvwasi/" | ||
|
||
echo "Copying new files to deps folder" | ||
cp -r "$UVWASI_ZIP/include" "$DEPS_DIR/uvwasi/" | ||
cp -r "$UVWASI_ZIP/src" "$DEPS_DIR/uvwasi/" | ||
cp "$UVWASI_ZIP/LICENSE" "$DEPS_DIR/uvwasi/" | ||
rm -rf "$UVWASI_ZIP" | ||
|
||
echo "All done!" | ||
echo "" | ||
echo "Please git add uvwasi, commit the new version:" | ||
echo "" | ||
echo "$ git add -A deps/uvwasi" | ||
echo "$ git commit -m \"deps: update uvwasi to $NEW_VERSION\"" | ||
echo "" | ||
echo "Make sure to update the deps/uvwasi/uvwasi.gyp if any significant changes have occurred upstream" | ||
echo "" | ||
|
||
# The last line of the script should always print the new version, | ||
# as we need to add it to $GITHUB_ENV variable. | ||
echo "NEW_VERSION=$NEW_VERSION" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any way to check this in the update script and to generate a warning/info message if there are new files found?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That’s a valid point, maybe @marco-ippolito already faced something alike in other scripts, I'll ask him!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the first attempt of automating gyp file update #47482, let's see how it goes and if its reliable we can add it to other dependencies.
For the time being I'd add a warn like:
echo "Make sure to update the deps/uvwasi/uvwasi.gyp if any significant changes have occurred upstream"
in the bash script