-
Notifications
You must be signed in to change notification settings - Fork 30.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: change WPT status files into CommonJS files #45826
Conversation
I've also considered yaml or json5 but felt CJS is more at home here and the present js linter can maintain the status files better. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
I will deal with merge conflicts when landing this. |
f9de90d
to
39c0f19
Compare
cc @nodejs/testing |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
39c0f19
to
414ba16
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RSLGTM with a nit.
414ba16
to
98de155
Compare
actually, not going to bother atm with ideas around the WPTRunner still in flight |
This PR updates the WPT status files to be
.js
files.The motivation for this change is to be able to use the javascript syntax to minimize the likelyhood of conflicts when adding/removing expectations and to allow for comments to be added for test blocks that may be failing for a specificic reason.
This would also allow to make more failures optional depending on config rather than current workaround being flaky, e.g. the
console
expectations file could be:The linter is configured to support that (newline for every array element, newline for array brackets).
max-len
is disabled because we cannot control the length of WPT test names and want them to fit on a single line.