Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V16.18.0 proposal #44886

Merged
merged 336 commits into from
Oct 12, 2022
Merged

V16.18.0 proposal #44886

merged 336 commits into from
Oct 12, 2022

Conversation

juanarbol
Copy link
Member

@juanarbol juanarbol commented Oct 4, 2022 •
edited
Loading

2022-10-12, Version 16.18.0 'Gallium' (LTS), @juanarbol

Notable changes

  • [1cc050eaa8] - (SEMVER-MINOR) assert: add getCalls and reset to callTracker (Moshe Atlow) #44191
  • [e5c9975f11] - (SEMVER-MINOR) crypto: allow zero-length secret KeyObject (Filip Skokan) #44201
  • [317cd051ce] - (SEMVER-MINOR) crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) #44201
  • [f80bdc5ef3] - (SEMVER-MINOR) doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588
  • [8398e98b1b] - (SEMVER-MINOR) http: make idle http parser count configurable (theanarkh) #43974
  • [2cd2f56962] - (SEMVER-MINOR) http: throw error on content-length mismatch (sidwebworks) #44378
  • [6be761e8a9] - (SEMVER-MINOR) lib: add diagnostics channel for process and worker (theanarkh) #44045
  • [1400796cef] - (SEMVER-MINOR) net,tls: pass a valid socket on tlsClientError (Daeyeon Jeong) #44021
  • [092239a7f1] - (SEMVER-MINOR) net: add local family (theanarkh) #43975
  • [381e11e18e] - (SEMVER-MINOR) report: expose report public native apis (Chengzhong Wu) #44255
  • [2ba547aa5b] - (SEMVER-MINOR) src: expose environment RequestInterrupt api (Chengzhong Wu) #44362
  • [6ed3367155] - (SEMVER-MINOR) stream: add ReadableByteStream.tee() (Daeyeon Jeong) #44505
  • [0fbedac6ce] - (SEMVER-MINOR) test_runner: add before/after/each hooks (Moshe Atlow) #43730
  • [70563b53c5] - (SEMVER-MINOR) util: add maxArrayLength option to Set and Map (Kohei Ueno) #43576

Commits

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dependencies Pull requests that update a dependency file. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. v16.x labels Oct 4, 2022
@juanarbol
Copy link
Member Author

Hey! Sorry for the delay; as you may see, the branch-diff output was quite large.

This proposal is failing in the "test-doc" job; due to #44477 not being part of this proposal and #44588 being included.

This is the test-doc output:

=== release test-deprecation-codes ===
Path: doctool/test-deprecation-codes
node:internal/process/esm_loader:97
    internalBinding('errors').triggerUncaughtException(
                              ^

AssertionError [ERR_ASSERTION]: Ill-formed or out-of-order deprecation code.
    at <anonymous> (/home/juanarbol/GitHub/node/doc/api/deprecations.md:3156:1)
    at testHeading (file:///home/juanarbol/GitHub/node/tools/doc/deprecationCodes.mjs:27:12)
    at file:///home/juanarbol/GitHub/node/tools/doc/deprecationCodes.mjs:87:5
    at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
    at async Promise.all (index 0)
    at async ESMLoader.import (node:internal/modules/esm/loader:526:24)
    at async loadESM (node:internal/process/esm_loader:91:5)
    at async handleMainPromise (node:internal/modules/run_main:65:12) {
  generatedMessage: false,
  code: 'ERR_ASSERTION',
  actual: 'DEP0167: ',
  expected: 'DEP0166: ',
  operator: 'strictEqual'
}

I have no idea what to do with this case. It would be fantastic if anyone can give me a picture or something!

On the other hand, exceptional thanks to the back-porters! You all were faster than me in preparing the release (@MoLow, impressive); sadly, I postponed this release by three days, and I could not include all of them.

juanarbol added a commit that referenced this pull request Oct 4, 2022
@juanarbol
2022-10-04, Version 16.18.0 'Gallium' (LTS)
67ad2ee 
Notable changes:

* doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588
* http: throw error on content-length mismatch (sidwebworks) #44378
* lib: add diagnostics channel for process and worker (theanarkh) #44045
* os: add machine method (theanarkh) #44416
* report: expose report public native apis (Chengzhong Wu) #44255
* src: expose environment RequestInterrupt api (Chengzhong Wu) #44362
* stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) #44505
* util: add `maxArrayLength` option to Set and Map (Kohei Ueno) #43576

PR-URL: #44886
@juanarbol
Copy link
Member Author

I need to rebase to repair the linter; I will do that tomorrow. The changelog will be the same, it is just a cosmetic change and it will change almost all the commit SHAs :/

@richardlau
Copy link
Member

This proposal is failing in the "test-doc" job; due to #44477 not being part of this proposal and #44588 being included.

I have no idea what to do with this case. It would be fantastic if anyone can give me a picture or something!

In the commit for #44588 that adds the DEP0167 deprecation amend doc/api/deprecations.md to skip the missing number:
e.g.

<!-- md-lint skip-deprecation DEP0166 -->

(see the line for DEP0159

node/doc/api/deprecations.md

Line 3055 in 5fc9d3c

<!-- md-lint skip-deprecation DEP0159 -->
for prior example).

Amending the commit will allow the tests to pass for that commit and avoids the tests being broken in one commit and then fixed up later.

@panva
Copy link
Member

panva commented Oct 4, 2022 •
edited
Loading

@juanarbol #44872 is good to be included (it fails CI for the same, unknown to me, reasons as this will).

juanarbol added a commit that referenced this pull request Oct 4, 2022
@juanarbol
2022-10-04, Version 16.18.0 'Gallium' (LTS)
07230b6 
Notable changes:

* doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588
* http: throw error on content-length mismatch (sidwebworks) #44378
* lib: add diagnostics channel for process and worker (theanarkh) #44045
* os: add machine method (theanarkh) #44416
* report: expose report public native apis (Chengzhong Wu) #44255
* src: expose environment RequestInterrupt api (Chengzhong Wu) #44362
* stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) #44505
* util: add `maxArrayLength` option to Set and Map (Kohei Ueno) #43576

PR-URL: #44886
@juanarbol
Copy link
Member Author

This proposal is failing in the "test-doc" job; due to #44477 not being part of this proposal and #44588 being included.
I have no idea what to do with this case. It would be fantastic if anyone can give me a picture or something!

In the commit for #44588 that adds the DEP0167 deprecation amend doc/api/deprecations.md to skip the missing number: e.g.

<!-- md-lint skip-deprecation DEP0166 -->

(see the line for DEP0159

node/doc/api/deprecations.md

Line 3055 in 5fc9d3c

<!-- md-lint skip-deprecation DEP0159 -->

for prior example).
Amending the commit will allow the tests to pass for that commit and avoids the tests being broken in one commit and then fixed up later.

That's what I did! Thank you! That fixes everything!

@juanarbol
Copy link
Member Author

@juanarbol #44872 is good to be included (it fails CI for the same, unknown to me, reasons as this will).

#44872 (comment) :)

@VoltrexKeyva VoltrexKeyva added release Issues and PRs related to Node.js releases. needs-ci PRs that need a full CI run. and removed doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. dependencies Pull requests that update a dependency file. labels Oct 5, 2022
@panva
Copy link
Member

panva commented Oct 5, 2022 •
edited
Loading

parallel/test-net-socket-connect-without-cb and parallel/test-net-socket-ready-without-cb fail on v16.x-staging as well as all open, otherwise good to go, backport PRs

not ok 2000 parallel/test-net-socket-ready-without-cb
  ---
  duration_ms: 0.173
  severity: fail
  exitcode: 1
  stack: |-
    node:events:491
          throw er; // Unhandled 'error' event
          ^
    
    Error: connect EADDRNOTAVAIL ::1:35463 - Local (:::0)
        at internalConnect (node:net:1041:16)
        at defaultTriggerAsyncIdScope (node:internal/async_hooks:464:18)
        at GetAddrInfoReqWrap.emitLookup [as callback] (node:net:1197:9)
        at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:111:8)
    Emitted 'error' event on Socket instance at:
        at emitErrorNT (node:internal/streams/destroy:157:8)
        at emitErrorCloseNT (node:internal/streams/destroy:122:3)
        at processTicksAndRejections (node:internal/process/task_queues:83:21) {
      errno: -99,
      code: 'EADDRNOTAVAIL',
      syscall: 'connect',
      address: '::1',
      port: 35463
    }
  ...

not ok 1990 parallel/test-net-socket-connect-without-cb
  ---
  duration_ms: 0.149
  severity: fail
  exitcode: 1
  stack: |-
    node:events:491
          throw er; // Unhandled 'error' event
          ^
    
    Error: connect EADDRNOTAVAIL ::1:45721 - Local (:::0)
        at internalConnect (node:net:1041:16)
        at defaultTriggerAsyncIdScope (node:internal/async_hooks:464:18)
        at GetAddrInfoReqWrap.emitLookup [as callback] (node:net:1197:9)
        at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:111:8)
    Emitted 'error' event on Socket instance at:
        at emitErrorNT (node:internal/streams/destroy:157:8)
        at emitErrorCloseNT (node:internal/streams/destroy:122:3)
        at processTicksAndRejections (node:internal/process/task_queues:83:21) {
      errno: -99,
      code: 'EADDRNOTAVAIL',
      syscall: 'connect',
      address: '::1',
      port: 45721
    }
  ...

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 5, 2022 •
edited by juanarbol
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/47095/
CITGM: https://ci.nodejs.org/job/citgm-smoker/3009/

Note: v8-CI is not required; there are no changes in v8 for this release.

@github-actions github-actions bot mentioned this pull request Oct 6, 2022
Open
25 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47106/

panva and others added 9 commits October 11, 2022 14:45
@panva @juanarbol
test: update WPT runner
14c7f4a 
PR-URL: #43455
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
Backport-PR-URL: #44872
@panva @juanarbol
crypto: fix webcrypto generateKey() AES key length validation error
a6e2cb4 
PR-URL: #44170
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: #44872
@panva @juanarbol
crypto: fix webcrypto operation errors to be OperationError
2c938d7 
PR-URL: #44171
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: #44872
@panva @juanarbol
crypto: fix webcrypto EC key namedCurve validation errors
7ad2a26 
PR-URL: #44172
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: #44872
@panva @juanarbol
crypto: fix webcrypto deriveBits validations
7e705d8 
PR-URL: #44173
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: #44872
@panva @juanarbol
crypto: allow zero-length secret KeyObject
e5c9975 
PR-URL: #44201
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: #44872
@panva @juanarbol
crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2
317cd05 
PR-URL: #44201
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Backport-PR-URL: #44872
@panva @juanarbol
test,crypto: update WebCryptoAPI WPT
4ebb3ef 
PR-URL: #44223
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Feng Yu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: LiviaMedeiros <[email protected]>
Backport-PR-URL: #44872
@joyeecheung @juanarbol
tools: increase timeout of running WPT
18e1766 
We run all WPT from one subset in the same process using workers.
As the number of the tests grow, it can take longer to run some of the
subsets, but it's still overall faster than running them in different
processes. This patch increases the timeout
for WPT to prevent the test from failing because it takes longer
to run (even though it would still complete at some point).

Refs: nodejs/reliability#371
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
PR-URL: #44574
Backport-PR-URL: #44872
juanarbol added a commit that referenced this pull request Oct 11, 2022
@juanarbol
2022-10-12, Version 16.18.0 'Gallium' (LTS)
071e35b 
Notable changes:

assert: add `getCalls` and `reset` to callTracker (Moshe Atlow) #44191
crypto: allow zero-length secret KeyObject (Filip Skokan) #44201
crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) #44201
doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588
http: make idle http parser count configurable (theanarkh) #43974
http: throw error on content-length mismatch (sidwebworks) #44378
lib: add diagnostics channel for process and worker (theanarkh) #44045
net,tls: pass a valid socket on `tlsClientError` (Daeyeon Jeong) #44021
net: add local family (theanarkh) #43975
report: expose report public native apis (Chengzhong Wu) #44255
src: expose environment RequestInterrupt api (Chengzhong Wu) #44362
stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) #44505
test_runner: add before/after/each hooks (Moshe Atlow) #43730
util: add `maxArrayLength` option to Set and Map (Kohei Ueno) #43576

PR-URL: #44886
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47188/

@github-actions github-actions bot mentioned this pull request Oct 12, 2022
Open
19 tasks
@juanarbol
2022-10-12, Version 16.18.0 'Gallium' (LTS)
90af1d6 
Notable changes:

assert: add `getCalls` and `reset` to callTracker (Moshe Atlow) #44191
crypto: allow zero-length secret KeyObject (Filip Skokan) #44201
crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) #44201
doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588
http: make idle http parser count configurable (theanarkh) #43974
http: throw error on content-length mismatch (sidwebworks) #44378
lib: add diagnostics channel for process and worker (theanarkh) #44045
net,tls: pass a valid socket on `tlsClientError` (Daeyeon Jeong) #44021
net: add local family (theanarkh) #43975
report: expose report public native apis (Chengzhong Wu) #44255
src: expose environment RequestInterrupt api (Chengzhong Wu) #44362
stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) #44505
test_runner: add before/after/each hooks (Moshe Atlow) #43730
util: add `maxArrayLength` option to Set and Map (Kohei Ueno) #43576

PR-URL: #44886
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 12, 2022 •
edited by juanarbol
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/47208/ ✔️
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3014/ ❓
iojs+release: https://ci-release.nodejs.org/job/iojs+release/8842/ ✔️

@juanarbol juanarbol merged commit 90af1d6 into v16.x Oct 12, 2022
@juanarbol juanarbol deleted the v16.18.0-proposal branch October 12, 2022 14:04
juanarbol added a commit that referenced this pull request Oct 12, 2022
@juanarbol
Working on v16.18.1
7051ba4 
PR-URL: #44886
juanarbol added a commit that referenced this pull request Oct 12, 2022
@juanarbol
2022-10-12, Version 16.18.0 'Gallium' (LTS)
e23c256 
Notable changes:

assert: add `getCalls` and `reset` to callTracker (Moshe Atlow) #44191
crypto: allow zero-length secret KeyObject (Filip Skokan) #44201
crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) #44201
doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588
http: make idle http parser count configurable (theanarkh) #43974
http: throw error on content-length mismatch (sidwebworks) #44378
lib: add diagnostics channel for process and worker (theanarkh) #44045
net,tls: pass a valid socket on `tlsClientError` (Daeyeon Jeong) #44021
net: add local family (theanarkh) #43975
report: expose report public native apis (Chengzhong Wu) #44255
src: expose environment RequestInterrupt api (Chengzhong Wu) #44362
stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) #44505
test_runner: add before/after/each hooks (Moshe Atlow) #43730
util: add `maxArrayLength` option to Set and Map (Kohei Ueno) #43576

PR-URL: #44886
@juanarbol juanarbol mentioned this pull request Oct 12, 2022
Merged
juanarbol added a commit to juanarbol/nodejs.org that referenced this pull request Oct 12, 2022
@juanarbol
Blog: v16.18.0 release post
06e007f 
Refs: nodejs/node#44886
@kwin kwin mentioned this pull request Dec 12, 2022
Open
6 tasks
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@juanarbol @guangwong
2022-10-12, Version 16.18.0 'Gallium' (LTS)
d5ae7ee 
Notable changes:

assert: add `getCalls` and `reset` to callTracker (Moshe Atlow) nodejs/node#44191
crypto: allow zero-length secret KeyObject (Filip Skokan) nodejs/node#44201
crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) nodejs/node#44201
doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) nodejs/node#44588
http: make idle http parser count configurable (theanarkh) nodejs/node#43974
http: throw error on content-length mismatch (sidwebworks) nodejs/node#44378
lib: add diagnostics channel for process and worker (theanarkh) nodejs/node#44045
net,tls: pass a valid socket on `tlsClientError` (Daeyeon Jeong) nodejs/node#44021
net: add local family (theanarkh) nodejs/node#43975
report: expose report public native apis (Chengzhong Wu) nodejs/node#44255
src: expose environment RequestInterrupt api (Chengzhong Wu) nodejs/node#44362
stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) nodejs/node#44505
test_runner: add before/after/each hooks (Moshe Atlow) nodejs/node#43730
util: add `maxArrayLength` option to Set and Map (Kohei Ueno) nodejs/node#43576

PR-URL: nodejs/node#44886
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@juanarbol @guangwong
Working on v16.18.1
a3bb349 
PR-URL: nodejs/node#44886
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@juanarbol @guangwong
2022-10-12, Version 16.18.0 'Gallium' (LTS)
54a488d 
Notable changes:

assert: add `getCalls` and `reset` to callTracker (Moshe Atlow) nodejs/node#44191
crypto: allow zero-length secret KeyObject (Filip Skokan) nodejs/node#44201
crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) nodejs/node#44201
doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) nodejs/node#44588
http: make idle http parser count configurable (theanarkh) nodejs/node#43974
http: throw error on content-length mismatch (sidwebworks) nodejs/node#44378
lib: add diagnostics channel for process and worker (theanarkh) nodejs/node#44045
net,tls: pass a valid socket on `tlsClientError` (Daeyeon Jeong) nodejs/node#44021
net: add local family (theanarkh) nodejs/node#43975
report: expose report public native apis (Chengzhong Wu) nodejs/node#44255
src: expose environment RequestInterrupt api (Chengzhong Wu) nodejs/node#44362
stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) nodejs/node#44505
test_runner: add before/after/each hooks (Moshe Atlow) nodejs/node#43730
util: add `maxArrayLength` option to Set and Map (Kohei Ueno) nodejs/node#43576

PR-URL: nodejs/node#44886
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
@juanarbol @guangwong
Working on v16.18.1
63bd402 
PR-URL: nodejs/node#44886
@tryonelove tryonelove mentioned this pull request Mar 28, 2023
Open
@sunghwan2789 sunghwan2789 mentioned this pull request Apr 21, 2023
Closed
7 tasks
@sbenmoussati sbenmoussati mentioned this pull request Jul 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams danielleadams approved these changes

@tniessen tniessen tniessen approved these changes

@panva panva panva approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. release Issues and PRs related to Node.js releases.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.