Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo in test-stream-toArray #41634

Merged
merged 1 commit into from
Jan 21, 2022
Merged

test: fix typo in test-stream-toArray #41634

merged 1 commit into from
Jan 21, 2022

Conversation

tniessen
Copy link
Member

Refs: #41553

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 21, 2022
@tniessen tniessen added request-ci Add this label to start a Jenkins CI on a PR. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 21, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @tniessen. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 21, 2022
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42075/

@benjamingr benjamingr added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41634
✔  Done loading data for nodejs/node/pull/41634
----------------------------------- PR info ------------------------------------
Title      test: fix typo in test-stream-toArray (#41634)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     tniessen:test-stream-toarray-typo -> nodejs:master
Labels     test, fast-track, needs-ci
Commits    1
 - test: fix typo in test-stream-toArray
Committers 1
 - Tobias Nießen 
PR-URL: https://github.com/nodejs/node/pull/41634
Refs: https://github.com/nodejs/node/pull/41553
Reviewed-By: Richard Lau 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Mestery 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41634
Refs: https://github.com/nodejs/node/pull/41553
Reviewed-By: Richard Lau 
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Mestery 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 21 Jan 2022 19:45:04 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41634#pullrequestreview-859983016
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41634#pullrequestreview-860008201
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41634#pullrequestreview-860051348
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41634#pullrequestreview-860083243
   ℹ  This PR is being fast-tracked
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2022-01-21T21:34:43Z: https://ci.nodejs.org/job/node-test-pull-request/42075/
- Querying data for job/node-test-pull-request/42075/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1731128221

@tniessen tniessen added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 21, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 21, 2022
@nodejs-github-bot nodejs-github-bot merged commit d0ea81c into nodejs:master Jan 21, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in d0ea81c

BethGriggs pushed a commit that referenced this pull request Jan 25, 2022
@tniessen @BethGriggs
test: fix typo in test-stream-toArray
55adcb7 
Refs: #41553

PR-URL: #41634
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@github-actions github-actions bot mentioned this pull request Jan 26, 2022
Open
26 tasks
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@tniessen @Linkgoron
test: fix typo in test-stream-toArray
05ce308 
Refs: nodejs#41553

PR-URL: nodejs#41634
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@ruyadorno ruyadorno mentioned this pull request Feb 8, 2022
Merged
@danielleadams danielleadams added the semver-minor PRs that contain new features and should be released in the next minor version. label Feb 27, 2022
@danielleadams

This comment was marked as outdated.

Sign in to view
@danielleadams danielleadams mentioned this pull request Feb 27, 2022
Merged
@danielleadams danielleadams added backport-blocked-v16.x and removed semver-minor PRs that contain new features and should be released in the next minor version. labels Mar 2, 2022
targos pushed a commit that referenced this pull request Jul 31, 2022
@tniessen @targos
test: fix typo in test-stream-toArray
f99b0d0 
Refs: #41553

PR-URL: #41634
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@targos targos mentioned this pull request Aug 3, 2022
Merged
guangwong pushed a commit to noslate-project/node that referenced this pull request Oct 10, 2022
@tniessen @guangwong
test: fix typo in test-stream-toArray
12aa8aa 
Refs: nodejs/node#41553

PR-URL: nodejs/node#41634
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Mestery <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mesteery Mesteery Mesteery approved these changes

@richardlau richardlau richardlau approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@tniessen @nodejs-github-bot @danielleadams @Trott @benjamingr @richardlau @Mesteery @targos