doc: document JavaScript tool for benchmark comparison #39835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
reviewed
Aug 22, 2021
jasnell
approved these changes
Aug 23, 2021
Lxxyx
approved these changes
Aug 24, 2021
This makes it simpler for everyone to do the statistical analysis since it doesn't require to install R and its dependencies. Refs: https://github.com/targos/node-benchmark-compare
lpinca
reviewed
Aug 25, 2021
Co-authored-by: Luigi Pinca <[email protected]>
lpinca
approved these changes
Aug 25, 2021
targos
added
the
author ready
wa-Nadoo
reviewed
Aug 25, 2021
|
|
||
| ```console | ||
| $ cat compare-pr-5134.csv | Rscript benchmark/compare.R | ||
| $ node-benchmark-compare compare-pr-5134.csv # or cat compare-pr-5134.csv | Rscript benchmark/compare.R |
There was a problem hiding this comment.
We can use npx tool to run global dependencies without installing.
Suggested change
| $ node-benchmark-compare compare-pr-5134.csv # or cat compare-pr-5134.csv | Rscript benchmark/compare.R | |
| $ npx node-benchmark-compare compare-pr-5134.csv # or cat compare-pr-5134.csv | Rscript benchmark/compare.R |
There was a problem hiding this comment.
yes, we can but the user was instructed earlier to install the dependency
There was a problem hiding this comment.
IMHO, this step should be removed to simplify user workflow
jasnell
pushed a commit
that referenced
this pull request
Aug 28, 2021
This makes it simpler for everyone to do the statistical analysis since it doesn't require to install R and its dependencies. Refs: https://github.com/targos/node-benchmark-compare PR-URL: #39835 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 449147e |
targos
added a commit
that referenced
this pull request
Sep 6, 2021
This makes it simpler for everyone to do the statistical analysis since it doesn't require to install R and its dependencies. Refs: https://github.com/targos/node-benchmark-compare PR-URL: #39835 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
targos
added a commit
that referenced
this pull request
Sep 6, 2021
This makes it simpler for everyone to do the statistical analysis since it doesn't require to install R and its dependencies. Refs: https://github.com/targos/node-benchmark-compare PR-URL: #39835 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Zijian Liu <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it simpler for everyone to do the statistical analysis since
it doesn't require to install R and its dependencies.
Refs: https://github.com/targos/node-benchmark-compare