Revert "test: mark test-cluster-bind-privileged-port flaky on arm" #36884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: nodejs#36850 Ref: nodejs#36847 Ref: nodejs/build#2521
cjihrig
approved these changes
Jan 12, 2021
gireeshpunathil
approved these changes
Jan 12, 2021
richardlau
approved these changes
Jan 12, 2021
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
watilde
approved these changes
Jan 12, 2021
AshCripps
approved these changes
Jan 12, 2021
lpinca
approved these changes
Jan 12, 2021
jasnell
approved these changes
Jan 12, 2021
Trott
approved these changes
Jan 13, 2021
There was a problem hiding this comment.
LGTM. I wonder if as a next step, the test should be modified to allow for either no error or a check that the expected error appears and is propagated. Then the test would at least work no matter where it was run and we wouldn't have to maintain privileged port configuration on Build hosts.
aduh95
pushed a commit
that referenced
this pull request
Jan 18, 2021
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: #36850 Ref: #36847 Ref: nodejs/build#2521 PR-URL: #36884 Refs: #36850 Refs: #36847 Refs: nodejs/build#2521 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Landed in 5716130 |
ruyadorno
pushed a commit
that referenced
this pull request
Jan 22, 2021
This reverts commit a45a404. Solved by marking ports <1024 as privileged on Docker containers. Ref: #36850 Ref: #36847 Ref: nodejs/build#2521 PR-URL: #36884 Refs: #36850 Refs: #36847 Refs: nodejs/build#2521 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daijiro Wachi <[email protected]> Reviewed-By: Ash Cripps <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a45a404.
Solved by marking ports <1024 as privileged on Docker containers.
Ref: #36850
Ref: #36847
Ref: nodejs/build#2521
/cc @nodejs/build