doc: add method links in dns.markdown #3196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| to perform name resolution in the same way that other applications on the same | ||
| operating system behave should use `dns.lookup`.__ | ||
| operating system behave should use [`dns.lookup()`](#dns_dns_lookup_hostname_options_callback).__ |
There was a problem hiding this comment.
When you are using the same thing again and again you can add the reference at the bottom.
There was a problem hiding this comment.
@thefourtheye oh yeah I forgot about that, thanks.
Added links to referenced methods.
mscdex
added
doc
|
LGTM |
silverwind
pushed a commit
that referenced
this pull request
Oct 9, 2015
Added links to referenced methods. PR-URL: #3196 Reviewed-By: Roman Reiss <[email protected]>>
|
Thanks! Landed in 70c78c9. |
jasnell
pushed a commit
that referenced
this pull request
Oct 10, 2015
Added links to referenced methods. PR-URL: #3196 Reviewed-By: Roman Reiss <[email protected]>>
|
landed in v4.x in 6dd3476 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added links to referenced methods and added parenthesis to follow consistency.