Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add cb error test for fs.close method #29970

Closed
wants to merge 3 commits into from
Closed

test: add cb error test for fs.close method #29970

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f489a52
test: add cb error test for fs.close method
teorossi82 Oct 14, 2019
dcd979a
test: avoid block scope in cb error test for fs.close method
teorossi82 Oct 15, 2019
d31e2de
test: added closeSync
teorossi82 Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions test/parallel/test-fs-close-errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,16 @@ const fs = require('fs');
assert.throws(() => fs.close(input), errObj);
assert.throws(() => fs.closeSync(input), errObj);
});

{
// Test error when cb is not a function
const fd = fs.openSync(__filename, 'r');

['', false, null, {}, []].forEach((input) => {
const errObj = {
code: 'ERR_INVALID_CALLBACK',
name: 'TypeError'
};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit-pick: You can move the errObj definition outside of the forEach() to below the fd definition. This way, it's only being defined once.

assert.throws(() => fs.close(fd, input), errObj);
});
}