bindings: close after reading module struct #2792
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not let the module struct to be deallocated by `uv_dclose` before reading data from it.
|
LGTM |
| char errmsg[1024]; | ||
| snprintf(errmsg, | ||
| sizeof(errmsg), | ||
| "Module version mismatch. Expected %d, got %d.", | ||
| NODE_MODULE_VERSION, mp->nm_version); | ||
| uv_dlclose(&lib); |
There was a problem hiding this comment.
mp->nm_version is a pointer to memory from the shared object? Can you add a comment explaining that? It's not very obvious from just looking at the code.
There was a problem hiding this comment.
It is, I'll add the comment.
ChALkeR
added
the
c++
|
|
|
LGTM2 |
indutny
added a commit
that referenced
this pull request
Sep 10, 2015
Do not let the module struct to be deallocated by `uv_dlclose` before reading data from it. PR-URL: #2792 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]>
|
Landed in a6d674d, thank you! |
|
@rvagg I suggest to backport this to 4.0 |
indutny
added a commit
that referenced
this pull request
Sep 11, 2015
Do not let the module struct to be deallocated by `uv_dlclose` before reading data from it. PR-URL: #2792 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]>
indutny
added a commit
that referenced
this pull request
Sep 12, 2015
Do not let the module struct to be deallocated by `uv_dlclose` before reading data from it. PR-URL: #2792 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Brian White <[email protected]> Reviewed-By: Yosuke Furukawa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not let the module struct to be deallocated by
uv_dclosebeforereading data from it.
Found it while investigating: #2791 (comment)
cc @nodejs/collaborators