Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: change deprecated method to recommended #13649

Closed
wants to merge 1 commit into from
Closed

test: change deprecated method to recommended #13649

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 13, 2017

In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test buffer stream tls zlib

@Trott
test: change deprecated method to recommended
b8354d7 
In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.
@Trott Trott added buffer Issues and PRs related to the buffer subsystem. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. zlib Issues and PRs related to the zlib subsystem. labels Jun 13, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 13, 2017
@mscdex
Copy link
Contributor

mscdex commented Jun 13, 2017 •
edited
Loading

LGTM if CI is ok: https://ci.nodejs.org/job/node-test-pull-request/8624/

@refack
Copy link
Contributor

refack commented Jun 13, 2017

ohh hello there:

311	parallel/test-dgram-implicit-bind	
duration_ms	0.442
severity	crashed
stack	oh no!
exit code: CRASHED (Signal: 11)

https://ci.nodejs.org/job/node-test-commit-freebsd/9699/nodes=freebsd11-x64/tapResults/
Ref: #13654

@refack
Copy link
Contributor

refack commented Jun 13, 2017

Rerun arm-fanned (infra fixed): https://ci.nodejs.org/job/node-test-commit-arm-fanned/9387/
Rerun freeBSD: https://ci.nodejs.org/job/node-test-commit-freebsd/9706/

jasnell
jasnell approved these changes Jun 13, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so long as we still have good test coverage on new Buffer() and Buffer()

tniessen
tniessen approved these changes Jun 14, 2017
View reviewed changes
Copy link
Member

@tniessen tniessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ARM is still having some unrelated problems.

Trott added a commit to Trott/io.js that referenced this pull request Jun 15, 2017
@Trott
test: change deprecated method to recommended
14f5a9b 
In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.

PR-URL: nodejs#13649
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Brian White <[email protected]>
@Trott
Copy link
Member Author

Trott commented Jun 15, 2017

Landed in 14f5a9b

@Trott Trott closed this Jun 15, 2017
addaleax pushed a commit that referenced this pull request Jun 17, 2017
@Trott @addaleax
test: change deprecated method to recommended
86daeb0 
In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.

PR-URL: #13649
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Brian White <[email protected]>
@addaleax addaleax mentioned this pull request Jun 17, 2017
Merged
addaleax pushed a commit that referenced this pull request Jun 21, 2017
@Trott @addaleax
test: change deprecated method to recommended
6920d5c 
In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.

PR-URL: #13649
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Brian White <[email protected]>
@addaleax addaleax mentioned this pull request Jun 21, 2017
Merged
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace the backport request label with do-not-land if it shouldn't land

Trott added a commit to Trott/io.js that referenced this pull request Jul 18, 2017
@Trott
test: change deprecated method to recommended
27f68cf 
In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.

PR-URL: nodejs#13649
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Brian White <[email protected]>
@Trott Trott mentioned this pull request Jul 18, 2017
Closed
4 tasks
@Trott
Copy link
Member Author

Trott commented Jul 18, 2017

6.x backport in #14339

MylesBorins pushed a commit that referenced this pull request Jul 18, 2017
@Trott @MylesBorins
test: change deprecated method to recommended
34fc7a0 
In non-buffer tests, change usage of the Buffer constructor to one of
the recommended alternatives.

Backport-PR-URL: #14339
PR-URL: #13649
Reviewed-By: Refael Ackermann <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Brian White <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 18, 2017
Merged
@Trott Trott deleted the set-a-good-example branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem. stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @mscdex @refack @MylesBorins @jasnell @lpinca @cjihrig @tniessen @nodejs-github-bot