Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove explicit UTF-8 validity check in url #11859

Closed
wants to merge 1 commit into from
Closed

src: remove explicit UTF-8 validity check in url #11859

wants to merge 1 commit into from

Conversation

TimothyGu
Copy link
Member

@TimothyGu TimothyGu commented Mar 15, 2017 •
edited
Loading

This step was never part of the URL Standard's host parser algorithm, and is rendered unnecessary after errors from ToASCII are no longer ignored.

Refs: c2a302c "src: do not ignore IDNA conversion error"
Refs: https://url.spec.whatwg.org/#concept-host-parser

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src, url

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Mar 15, 2017
@TimothyGu
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/6857/

jasnell
jasnell approved these changes Mar 15, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! Thank you! You just crossed an item off my todo list for me. Definitely appreciate that!

@TimothyGu
src: remove explicit UTF-8 validity check in url
7edcf47 
This step was never part of the URL Standard's host parser algorithm,
and is rendered unnecessary after IDNA errors are no longer ignored.

PR-URL: nodejs#11859
Refs: c2a302c "src: do not ignore IDNA conversion error"
Refs: https://url.spec.whatwg.org/#concept-host-parser
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@TimothyGu
Copy link
Member Author

Removed the now unused header inclusion too. Will land when CI passes.

CI: https://ci.nodejs.org/job/node-test-pull-request/6892/

@TimothyGu
Copy link
Member Author

Landed in d099f8e.

@TimothyGu TimothyGu closed this Mar 16, 2017
@TimothyGu TimothyGu deleted the url-utf8 branch March 16, 2017 23:40
TimothyGu added a commit that referenced this pull request Mar 16, 2017
@TimothyGu
src: remove explicit UTF-8 validity check in url
d099f8e 
This step was never part of the URL Standard's host parser algorithm,
and is rendered unnecessary after IDNA errors are no longer ignored.

PR-URL: #11859
Refs: c2a302c "src: do not ignore IDNA conversion error"
Refs: https://url.spec.whatwg.org/#concept-host-parser
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@TimothyGu @jungx098
src: remove explicit UTF-8 validity check in url
c06cb29 
This step was never part of the URL Standard's host parser algorithm,
and is rendered unnecessary after IDNA errors are no longer ignored.

PR-URL: nodejs#11859
Refs: c2a302c "src: do not ignore IDNA conversion error"
Refs: https://url.spec.whatwg.org/#concept-host-parser
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Daijiro Wachi <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@italoacasas
Copy link
Contributor

Need backport to v7

@jasnell jasnell mentioned this pull request Apr 4, 2017
Closed
@TimothyGu TimothyGu mentioned this pull request Apr 19, 2017
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@TimothyGu @italoacasas @bnoordhuis @jasnell @addaleax @watilde @cjihrig @nodejs-github-bot