Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test test-child-process-fork-net2 #2669

Closed
orangemocha opened this issue Sep 3, 2015 · 8 comments
Closed

Investigate flaky test test-child-process-fork-net2 #2669

orangemocha opened this issue Sep 3, 2015 · 8 comments
Labels
build Issues and PRs related to build files or the CI. child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Milestone

Comments

@orangemocha
Copy link
Contributor

Failed on SmartOS in this run: https://ci.nodejs.org/job/node-test-commit-other/423/nodes=smartos14-64/

Was deemed not related to the change in that PR: #2402

@orangemocha orangemocha added build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. labels Sep 3, 2015
@orangemocha orangemocha added this to the 5.0.0 milestone Sep 3, 2015
orangemocha added a commit to orangemocha/io.js that referenced this issue Sep 3, 2015
@brendanashworth brendanashworth added the child_process Issues and PRs related to the child_process subsystem. label Sep 3, 2015
@rvagg rvagg mentioned this issue Oct 16, 2015
13 tasks
@orangemocha orangemocha modified the milestones: 6.0.0, 5.0.0 Oct 19, 2015
@whitlockjc
Copy link
Contributor

I am unable to reproduce this on OS X, SmartOS or Ubuntu. With the latest master build, I ran the following and 100/100 tests run on all three tested environments:

time (OK=0; NOK=0; for i in `seq 100`; do ./node test/parallel/test-child-process-fork-net2.js && OK=$(($OK+1)) || NOK=$(($NOK+1)); echo "$i   OK: $OK   NOT OK: $NOK"; done)

Also, what about a smartos label for this?

@whitlockjc
Copy link
Contributor

Also, let me know if I messed up the reproduction recipe.

@bnoordhuis
Copy link
Member

FWIW, I haven't been able to reproduce this locally on OSX and Linux either.

@whitlockjc
Copy link
Contributor

Good to hear. :) I'll keep moving down the list and updating with either a PR or a similar update to this one.

@orangemocha
Copy link
Contributor Author

Thanks. FYI, we are coming up with a Jenkins job to stress individual tests in CI, so we can quickly verify if a test is really flaky or not.

@whitlockjc
Copy link
Contributor

Cool. I've got scripts on *nix and Windows to run similar tests like above. If I can help, let me know.

@Trott
Copy link
Member

Trott commented Nov 15, 2015

Given that the flakiness has not been reproduced, I'm going to close this. Anyone should feel absolutely free to re-open with no hesitation at all if you think I'm being rash or if the issue does re-appear.

@Trott Trott closed this as completed Nov 15, 2015
@orangemocha
Copy link
Contributor Author

Sounds good. Verified NOT flaky in CI: https://ci.nodejs.org/job/node-stress-single-test/4/nodes=smartos14-64/console

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

No branches or pull requests

5 participants