http2: log debug only when in debug mode

PR-URL: #43626 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ricky Zhou <[email protected]>
nodejs · Jul 8, 2022 · f3a92a0 · f3a92a0
1 parent 680dd7c
commit f3a92a0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -190,10 +190,10 @@ let debug = require('internal/util/debuglog').debuglog('http2', (fn) => {
   debug = fn;
 });
 
-// TODO(addaleax): See if this can be made more efficient by figuring out
-// whether debugging is enabled before we perform any further steps. Currently,
-// this seems pretty fast, though.
 function debugStream(id, sessionType, message, ...args) {
+  if (!debug.enabled) {
+    return;
+  }
   debug('Http2Stream %s [Http2Session %s]: ' + message,
         id, sessionName(sessionType), ...new SafeArrayIterator(args));
 }