hack: no pch

nodejs · Sep 30, 2020 · e0b3e1c · e0b3e1c
1 parent a238789
commit e0b3e1c
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 36 deletions.
diff --git a/node.gypi b/node.gypi
@@ -56,12 +56,12 @@
         'NOMINMAX',
         '_UNICODE=1',
       ],
-      'msvs_precompiled_header': 'tools/msvs/pch/node_pch.h',
-      'msvs_precompiled_source': 'tools/msvs/pch/node_pch.cc',
-      'sources': [
-        '<(_msvs_precompiled_header)',
-        '<(_msvs_precompiled_source)',
-      ],
+      # 'msvs_precompiled_header': 'tools/msvs/pch/node_pch.h',
+      # 'msvs_precompiled_source': 'tools/msvs/pch/node_pch.cc',
+      # 'sources': [
+      #   '<(_msvs_precompiled_header)',
+      #   '<(_msvs_precompiled_source)',
+      # ],
     }, { # POSIX
       'defines': [ '__POSIX__' ],
     }],

diff --git a/tools/v8_gypfiles/v8.gyp b/tools/v8_gypfiles/v8.gyp
@@ -460,14 +460,14 @@
              '<(V8_ROOT)/src/builtins/builtins-intl-gen.cc',
            ],
          }],
-        ['OS=="win"', {
-          'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
-          'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
-          'sources': [
-            '<(_msvs_precompiled_header)',
-            '<(_msvs_precompiled_source)',
-          ],
-        }],
+        # ['OS=="win"', {
+        #   'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
+        #   'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
+        #   'sources': [
+        #     '<(_msvs_precompiled_header)',
+        #     '<(_msvs_precompiled_source)',
+        #   ],
+        # }],
       ],
     },  # v8_initializers
     {
@@ -653,14 +653,14 @@
         ['want_separate_host_toolset', {
           'toolsets': ['host', 'target'],
         }],
-        ['OS=="win"', {
-          'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
-          'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
-          'sources': [
-            '<(_msvs_precompiled_header)',
-            '<(_msvs_precompiled_source)',
-          ],
-        }],
+        # ['OS=="win"', {
+        #   'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
+        #   'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
+        #   'sources': [
+        #     '<(_msvs_precompiled_header)',
+        #     '<(_msvs_precompiled_source)',
+        #   ],
+        # }],
       ],
     },  # v8_compiler_opt
     {
@@ -676,14 +676,14 @@
         ['want_separate_host_toolset', {
           'toolsets': ['host', 'target'],
         }],
-        ['OS=="win"', {
-          'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
-          'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
-          'sources': [
-            '<(_msvs_precompiled_header)',
-            '<(_msvs_precompiled_source)',
-          ],
-        }],
+        # ['OS=="win"', {
+        #   'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
+        #   'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
+        #   'sources': [
+        #     '<(_msvs_precompiled_header)',
+        #     '<(_msvs_precompiled_source)',
+        #   ],
+        # }],
       ],
     },  # v8_compiler
     {
@@ -838,12 +838,12 @@
           ],
         }],
         ['OS=="win"', {
-          'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
-          'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
-          'sources': [
-            '<(_msvs_precompiled_header)',
-            '<(_msvs_precompiled_source)',
-          ],
+          # 'msvs_precompiled_header': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.h',
+          # 'msvs_precompiled_source': '<(V8_ROOT)/../../tools/msvs/pch/v8_pch.cc',
+          # 'sources': [
+          #   '<(_msvs_precompiled_header)',
+          #   '<(_msvs_precompiled_source)',
+          # ],
           # This will prevent V8's .cc files conflicting with the inspector's
           # .cpp files in the same shard.
           'msvs_settings': {