src: fix stuck debugger process

The debug process running "node debug a.js" will be stuck when the script ends. This is because the debug handler has been unrefed. We shouldn't unref the debug handler to avoid this problem. PR-URL: #2778 Reviewed-By: Ben Noordhuis <[email protected]>
nodejs · Oct 28, 2015 · dee9c74 · dee9c74
1 parent 9061aa2
commit dee9c74
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/node.cc b/src/node.cc
@@ -3669,7 +3669,6 @@ void Init(int* argc,
   uv_async_init(uv_default_loop(),
                 &dispatch_debug_messages_async,
                 DispatchDebugMessagesAsyncCallback);
-  uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
 
 #if defined(NODE_V8_OPTIONS)
   // Should come before the call to V8::SetFlagsFromCommandLine()
@@ -3976,8 +3975,11 @@ static void StartNodeInstance(void* arg) {
     env->set_trace_sync_io(trace_sync_io);
 
     // Enable debugger
-    if (instance_data->use_debug_agent())
+    if (instance_data->use_debug_agent()) {
       EnableDebug(env);
+    } else {
+      uv_unref(reinterpret_cast<uv_handle_t*>(&dispatch_debug_messages_async));
+    }
 
     {
       SealHandleScope seal(isolate);