squash: address comments

Signed-off-by: Michael Dawson <[email protected]>
nodejs · Oct 24, 2023 · b6749db · b6749db
1 parent 09d6b13
commit b6749db
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/permission/fs_permission.cc b/src/permission/fs_permission.cc
@@ -211,7 +211,7 @@ void FSPermission::RadixTree::Insert(const std::string& path) {
 
     if (is_wildcard_node || is_last_char) {
       std::string node_path = path.substr(parent_node_prefix_len, i);
-      current_node = current_node->CreateChild(std::move(node_path));
+      current_node = current_node->CreateChild(node_path);
     }
 
     if (is_wildcard_node) {

diff --git a/src/permission/fs_permission.h b/src/permission/fs_permission.h
@@ -31,7 +31,7 @@ class FSPermission final : public PermissionBase {
 
       Node() : wildcard_child(nullptr), is_leaf(false) {}
 
-      Node* CreateChild(std::string prefix) {
+      Node* CreateChild(const std::string& prefix) {
         if (prefix.empty() && !is_leaf) {
           is_leaf = true;
           return this;