stream: fix writableStream.abort()

This includes: - Fixing `writableStream.abort(reason)`. Passing the reason was missing. - Leaving a TODO to remove the internal abortReason property of WritableStreamDefaultController. Signed-off-by: Daeyeon Jeong [email protected] PR-URL: #44327 Refs: https://streams.spec.whatwg.org/#writable-stream-abort Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
nodejs · Sep 26, 2022 · 9f755e1 · 9f755e1
1 parent 687ffcc
commit 9f755e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/lib/internal/webstreams/writablestream.js b/lib/internal/webstreams/writablestream.js
@@ -637,8 +637,11 @@ function writableStreamAbort(stream, reason) {
   if (state === 'closed' || state === 'errored')
     return PromiseResolve();
 
+  // TODO(daeyeon): Remove `controller[kState].abortReason` and use
+  // `controller[kState].abortController.signal.reason` for the
+  // `WritableStreamDefaultController.prototype.abortReason` getter.
   controller[kState].abortReason = reason;
-  controller[kState].abortController.abort();
+  controller[kState].abortController.abort(reason);
 
   if (stream[kState].pendingAbortRequest.abort.promise !== undefined)
     return stream[kState].pendingAbortRequest.abort.promise;

diff --git a/test/wpt/status/streams.json b/test/wpt/status/streams.json
@@ -80,10 +80,5 @@
   },
   "transferable/transfer-with-messageport.window.js": {
     "skip": "Browser-specific test"
-  },
-  "writable-streams/aborting.any.js": {
-    "fail": {
-      "expected": ["WritableStreamDefaultController.signal"]
-    }
   }
 }