url: revert "validate ipv4 part length"

This reverts commit 87d0d7a. Refs: #42915 PR-URL: #42940 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]> Reviewed-By: Rich Trott <[email protected]>
nodejs · Jun 11, 2022 · 8fc42d3 · 8fc42d3
1 parent 7d45e5f
commit 8fc42d3
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 11 deletions.
diff --git a/src/node_url.cc b/src/node_url.cc
@@ -411,11 +411,7 @@ void URLHost::ParseIPv4Host(const char* input, size_t length, bool* is_ipv4) {
     const char ch = pointer < end ? pointer[0] : kEOL;
     int64_t remaining = end - pointer - 1;
     if (ch == '.' || ch == kEOL) {
-      // If parts’s size is greater than 4, validation error, return failure.
-      if (++parts > static_cast<int>(arraysize(numbers))) {
-        *is_ipv4 = true;
-        return;
-      }
+      if (++parts > static_cast<int>(arraysize(numbers))) return;
       if (pointer == mark)
         return;
       int64_t n = ParseNumber(mark, pointer);

diff --git a/test/fixtures/wpt/url/resources/urltestdata.json b/test/fixtures/wpt/url/resources/urltestdata.json
@@ -5317,12 +5317,17 @@
   {
     "input": "http://256.256.256.256.256",
     "base": "http://other.com/",
-    "failure": true
-  },
-  {
-    "input": "http://256.256.256.256.256.",
-    "base": "http://other.com/",
-    "failure": true
+    "href": "http://256.256.256.256.256/",
+    "origin": "http://256.256.256.256.256",
+    "protocol": "http:",
+    "username": "",
+    "password": "",
+    "host": "256.256.256.256.256",
+    "hostname": "256.256.256.256.256",
+    "port": "",
+    "pathname": "/",
+    "search": "",
+    "hash": ""
   },
   {
     "input": "https://0x.0x.0",