fixup! dns: runtime deprecate type coercion of dns.lookup options

nodejs · Aug 17, 2021 · 4dee2c4 · 4dee2c4
1 parent 4528834
commit 4dee2c4
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 1 deletion.
diff --git a/doc/api/deprecations.md b/doc/api/deprecations.md
@@ -2793,7 +2793,7 @@ changes:
     pr-url: https://github.com/nodejs/node/pull/38906
     description: Documentation-only deprecation.
   - version: REPLACEME
-    pr-url: https://github.com/nodejs/node/pull/00000
+    pr-url: https://github.com/nodejs/node/pull/39793
     description: Runtime deprecation.
 -->
 

diff --git a/test/internet/test-dns-lookup.js b/test/internet/test-dns-lookup.js
@@ -44,3 +44,18 @@ dns.lookup(addresses.NOT_FOUND, {
   assert.strictEqual(error.syscall, 'getaddrinfo');
   assert.strictEqual(error.hostname, addresses.NOT_FOUND);
 }));
+
+common.expectWarning('DeprecationWarning',
+                     'Type coercion of dns.lookup options is deprecated',
+                     'DEP0153');
+
+assert.rejects(
+  dnsPromises.lookup(addresses.NOT_FOUND, {
+    family: 'IPv4',
+    all: 'all'
+  }),
+  {
+    code: 'ENOTFOUND',
+    message: `getaddrinfo ENOTFOUND ${addresses.NOT_FOUND}`
+  }
+);