Skip to content

Commit

Permalink
test: add override to ServerDone function
Browse files Browse the repository at this point in the history
Currently the following compiler warning is displayed when building:

  ../test/cctest/test_inspector_socket_server.cc:142:8: warning:
  'ServerDone' overrides a member function but is not marked 'override'
        [-Winconsistent-missing-override]
    void ServerDone() {
         ^
  ../src/inspector_socket_server.h:30:16: note: overridden virtual
  function is here
    virtual void ServerDone() = 0;
                 ^

This commit marks ServerDone with override to get rid of the warning.

PR-URL: #13166
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Refael Ackermann <[email protected]>
  • Loading branch information
danbev authored and addaleax committed May 25, 2017
1 parent 155687c commit 25ade76
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/cctest/test_inspector_socket_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ class TestInspectorServerDelegate : public SocketServerDelegate {
server_->Send(session_id_, message);
}

void ServerDone() {
void ServerDone() override {
done = true;
}

Expand Down

0 comments on commit 25ade76

Please sign in to comment.