Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Rich Trott <[email protected]>
  • Loading branch information
RafaelGSS and Trott authored May 17, 2024
1 parent b9cbde7 commit 18981b0
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion doc/api/cli.md
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ added: REPLACEME
When using the [Permission Model][], the process will not be able to create any
WASI instances by default.
For security reasons, the call will throw an `ERR_ACCESS_DENIED` unless the
user explicitly pass the flag `--allow-wasi` in the main Node.js process.
user explicitly passes the flag `--allow-wasi` in the main Node.js process.

Example:

Expand Down
4 changes: 2 additions & 2 deletions doc/api/permissions.md
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ flag.

When starting Node.js with `--experimental-permission`,
the ability to access the file system through the `fs` module, spawn processes,
use `node:worker_threads`, native addons, WASI, and enable the runtime inspector
use `node:worker_threads`, use native addons, use WASI, and enable the runtime inspector
will be restricted.

```console
Expand All @@ -507,7 +507,7 @@ Allowing access to spawning a process and creating worker threads can be done
using the [`--allow-child-process`][] and [`--allow-worker`][] respectively.

To allow native addons when using permission model, use the [`--allow-addons`][]
flag. For WASI, use the [`--allow-wasi`][]
flag. For WASI, use the [`--allow-wasi`][] flag.

#### Runtime API

Expand Down
2 changes: 1 addition & 1 deletion doc/node.1
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ Allow using native addons when using the permission model.
Allow spawning process when using the permission model.
.
.It Fl -allow-wasi
Allow creating WASI when using the permission model.
Allow execution of WASI when using the permission model.
.
.It Fl -allow-worker
Allow creating worker threads when using the permission model.
Expand Down

0 comments on commit 18981b0

Please sign in to comment.