Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support HTTPS_PROXY #1749

Closed
winstliu opened this issue May 12, 2019 · 2 comments
Closed

Support HTTPS_PROXY #1749

winstliu opened this issue May 12, 2019 · 2 comments

Comments

@winstliu
Copy link

  • Node Version: 10.15.3, 6.9.0
  • Platform: Windows Enterprise 10.0.18362 N/D Compilación 18362
  • Compiler: N/A
  • Module: N/A

node-gyp supports basic proxy options:

node-gyp/lib/install.js

Lines 432 to 435 in 721eb69

var proxyUrl = gyp.opts.proxy
|| env.http_proxy
|| env.HTTP_PROXY
|| env.npm_config_proxy

However, it doesn't look like it supports HTTPS_PROXY (and variants).
Would this be something that node-gyp is willing to support? I can create a PR if the answer is yes.
@bzoz
Copy link
Contributor

bzoz commented May 14, 2019

Sure, PRs are always welcomed!

winstliu pushed a commit to winstliu/node-gyp that referenced this issue May 14, 2019
install: support HTTPS_PROXY
9726745 
Fixes: nodejs#1749
@winstliu winstliu mentioned this issue May 14, 2019
Closed
4 tasks
@rvagg
Copy link
Member

rvagg commented Jun 21, 2019

closing in favour of PR @ #1751

@rvagg rvagg closed this as completed Jun 21, 2019
winstliu pushed a commit to winstliu/node-gyp that referenced this issue Jun 22, 2019
lib: support HTTPS_PROXY
d5dc6f6 
Fixes: nodejs#1749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rvagg @winstliu @bzoz