Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Drop support for MacOS prior to 13 #3876

Closed
UlisesGascon opened this issue Aug 28, 2024 · 4 comments
Closed

Proposal: Drop support for MacOS prior to 13 #3876

UlisesGascon opened this issue Aug 28, 2024 · 4 comments

Comments

@UlisesGascon
Copy link
Member

As discussed in #3874 (thanks @targos), it seems like we can rethink our strategy on supporting legacy versions of macOS.

Current Situation:
In Node:

  • Node 18 is tested on macOS 10.15, but since the change in the signing process, the signature is done on macOS 11.
  • Node 20 is tested and released on macOS 11.
  • Node 22 is tested and released on macOS 11.

Context:

  • Both macOS 10.15 and macOS 11 are EOL (end of life dates):
    • macOS 10.15 reached EOL on 12 Sep 2022.
    • macOS 11 reached EOL on 26 Sep 2023.
  • Homebrew no longer supports these versions, which means VM image building takes long hours, as we need to build all the OS dependencies from source, resulting in many errors.
  • Orka does not support macOS 11 ARM (related issue).
  • Not migrating MacOS 10.15 and 11 will save us a lot of time

Proposal:

cc: @nodejs/build, do you agree on dropping support for macOS 10.15 and 11? We propose using macOS 13 as the minimum version for Node 18 to Node 23.

Obviously, we will implement this deprecation progressively as part of the issue #3686 plan to avoid disruptions.

@targos
Copy link
Member

targos commented Aug 28, 2024

I am obviously in favor.
The -mmacosx-version-min flag should still make the builds compatible with the older versions.

https://github.com/nodejs/node/blob/4f14eb15454b9f6ae7f0145947debd2c79a2a84f/common.gypi#L630C12-L630C36

@mhdawson
Copy link
Member

@targos thanks that answers the question I was just about to ask. As long as the configuration maintains the same minimum osx version (which you confirmed it does) I'm +1 as well.

@sxa
Copy link
Member

sxa commented Aug 29, 2024

SGTM on the basis of continuing to use the -mmacosx-version-min flag to target the same as we do already. So this will become a policy of not actively testing on out-of-support versions of macos as opposed to removing the ability to run on them 👍🏻 I can't see any issue there.

@UlisesGascon
Copy link
Member Author

Thanks for all the feedback ❤️ !

Seems like we are very align on this, so I will close it and move on to MacOS 13. I will include -mmacosx-version-min in the pending tasks for #3686 so we keep it in the radar.

UlisesGascon added a commit that referenced this issue Aug 31, 2024
@UlisesGascon UlisesGascon self-assigned this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants