Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update review_guidelines.md #47

Merged
merged 2 commits into from
Jan 10, 2025
Merged

Update review_guidelines.md #47

merged 2 commits into from
Jan 10, 2025

Conversation

bmuenzenmeyer
Copy link
Contributor

See conversation in #44

@bmuenzenmeyer bmuenzenmeyer requested a review from a team as a code owner December 23, 2024 16:50
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 23, 2024
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@joyeecheung
Copy link
Member

I feel that we should probably need some criteria for what can be posted - in case people game the system and try to amplify ads and then it would be somewhat awkward to say no. But we can add a general sentence that it should be reviewed/proof-read by a TSC member.

Co-authored-by: Joyee Cheung <[email protected]>
@joyeecheung joyeecheung merged commit a39978c into main Jan 10, 2025
@joyeecheung joyeecheung deleted the bmuenzenmeyer-patch-1 branch January 10, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants