Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

N-API 6 #393

Closed
gabrielschulhof opened this issue Mar 2, 2020 · 3 comments
Closed

N-API 6 #393

gabrielschulhof opened this issue Mar 2, 2020 · 3 comments

Comments

@gabrielschulhof
Copy link
Collaborator

The only outstanding backport for new N-APIs is nodejs/node#31384 which brings napi_get_all_property_names to v10.x. Shall we wait until it lands to make off N-API 6 as including napi_get_all_property_names, or shall we leave napi_get_all_property_names experimental and roll N-API 6 without it?

Once we have arrived at a decision, we need to file a PR in core that bumps the NAPI_VERSION and updates the preprocessor if-block into which the N-API declarations are placed.
@legendecas
Copy link
Member

Since nodejs/node#31384 has landed on v10.x-staging as nodejs/node#31384 (comment), I'd believe we're going to roll N-API 6 with napi_get_all_property_names if there are no other issues arisen.

@mhdawson
Copy link
Member

mhdawson commented Mar 2, 2020

@gabrielschulhof looks like we are ready to go

@gabrielschulhof
Copy link
Collaborator Author

Excellent!

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Mar 7, 2020
@legendecas
n-api: define release 6
9f588c1 
Mark all N-APIs that have been added since version 5 as stable.

Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]>
MylesBorins pushed a commit to nodejs/node that referenced this issue Mar 9, 2020
@legendecas @MylesBorins
n-api: define release 6
710c905 
Mark all N-APIs that have been added since version 5 as stable.

PR-URL: #32058
Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Mar 25, 2020
@legendecas
n-api: define release 6
e1e2c2d 
Mark all N-APIs that have been added since version 5 as stable.

PR-URL: nodejs#32058
Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this issue Apr 2, 2020
@legendecas
n-api: define release 6
3a3c011 
Mark all N-APIs that have been added since version 5 as stable.

PR-URL: nodejs#32058
Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
BethGriggs pushed a commit to nodejs/node that referenced this issue Apr 6, 2020
@legendecas @BethGriggs
n-api: define release 6
e9c590e 
Mark all N-APIs that have been added since version 5 as stable.

PR-URL: #32058
Backport-PR-URL: #32488
Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit to targos/node that referenced this issue Apr 25, 2020
@legendecas @targos
n-api: define release 6
12b3fca 
Mark all N-APIs that have been added since version 5 as stable.

Backport-PR-URL: nodejs#32482
PR-URL: nodejs#32058
Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
targos pushed a commit to nodejs/node that referenced this issue Apr 28, 2020
@legendecas @targos
n-api: define release 6
e22d853 
Mark all N-APIs that have been added since version 5 as stable.

Backport-PR-URL: #32482
PR-URL: #32058
Fixes: nodejs/abi-stable-node#393
Co-Authored-By: legendecas <[email protected]>
Signed-off-by: Gabriel Schulhof <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gabrielschulhof @legendecas @mhdawson