Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove cachix action #5093

Merged
merged 3 commits into from
Mar 6, 2024
Merged

ci: remove cachix action #5093

merged 3 commits into from
Mar 6, 2024

Conversation

rycee
Copy link
Member

@rycee rycee commented Mar 5, 2024

All the extra binary cache lookups and uploads to Cachix make the build quite a bit slower than necessary.

@rycee rycee self-assigned this Mar 5, 2024
@terlar
Copy link
Contributor

terlar commented Mar 5, 2024

The uploads could be sped up with useDaemon: true as they then will be done async instead of at the end. But I guess if the cache lookup and cache download doesn't help much there is no need for it at all..

rycee added 3 commits March 6, 2024 08:42
All the extra binary cache lookups and uploads to Cachix make the
build quite a bit slower than necessary.
@rycee rycee force-pushed the remove-cachix-from-ci-tests branch from 206c190 to 3c7bacf Compare March 6, 2024 07:42
@rycee
Copy link
Member Author

rycee commented Mar 6, 2024

@terlar Thanks for the feedback. Yeah, I think our use-case (creating an enormous number of small files without pinning Nixpkgs) is not good for Cachix so it doesn't really make a difference in runtime, just adds unnecessary load on the Cachix servers.

I think we eventually would benefit from moving the CI out of GitHub actions into a system with direct and persistent access to a Nix store.

We also run a lot of unnecessary tests, ideally we would be able to tell which tests are affected by a given PR. For example, it is pretty unnecessary to run git module tests when the PR only changed something in the bat module.

@rycee rycee merged commit 3c7bacf into master Mar 6, 2024
3 checks passed
@rycee rycee deleted the remove-cachix-from-ci-tests branch March 6, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants