Fix issue aknuds1#52

nick-codes · Oct 6, 2017 · a0bc13e · a0bc13e
1 parent e510335
commit a0bc13e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/utils.js b/lib/utils.js
@@ -14,14 +14,14 @@ function createStyleJsonFromString(styleString) {
     if (singleStyle.length > 2) {
       singleStyle[1] = singleStyle.slice(1).join(':');
     }
-    
+
     key = camelize(singleStyle[0]);
     value = singleStyle[1];
     if (typeof value === 'string'){
       value = value.trim();
     }
 
-    if (key.length > 0 && value.length > 0) {
+    if (key && value && key.length > 0 && value.length > 0) {
       jsonStyles[key] = value;
     }
   }

diff --git a/test/html-to-react-tests.js b/test/html-to-react-tests.js
@@ -259,6 +259,15 @@ describe('Html2React', function () {
       var reactComponent = parser.parse(htmlInput);
       var reactHtml = ReactDOMServer.renderToStaticMarkup(reactComponent);
 
+      assert.equal(reactHtml, htmlExpected);
+    });
+    it('should handle invalid style tag', function () {
+      var htmlInput = '<div style="color:black;href="></div>';
+      var htmlExpected = '<div style="color:black"></div>';
+
+      var reactComponent = parser.parse(htmlInput);
+      var reactHtml = ReactDOMServer.renderToStaticMarkup(reactComponent);
+
       assert.equal(reactHtml, htmlExpected);
     });
   });