[Core] Fix a couple of standards-compliance issues with C99 #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for the work! Just quickly, could you walk me through what the compliance issue is for |
nicbarker
changed the title
|
Of course! Anonymous unions (i.e. unions in structs or other unions without a name) were only added in C11. See https://en.cppreference.com/w/c/language/union. |
Doesn't fix the ##__VA_ARGS__ warnings, as they aren't easily solved with pure C99. This only fixes the issues in the public code, more needs to be done to do the same for the implementation.
FintasticMan
force-pushed
the
standards-compliance-public
branch
from
731594f to
bc1032a
Compare
|
@nicbarker I've just updated to the latest main branch, as there were some conflicts. |
|
@FintasticMan thanks for the work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't fix the
##__VA_ARGS__warnings, as they aren't easily solved with pure C99.This only fixes the issues in the public code, more needs to be done to do the same for the implementation.
I guess this does cause an API change in the form of the
Clay_SizingAxisstruct being changed slightly, but I think everyone should be using the macros so it shouldn't matter that much.