Merge pull request #973 from nhsuk/adjust-error-summary-margin

Reduce error summary bottom margin
nhsuk · Jul 24, 2024 · bb1ee87 · bb1ee87
2 parents 817d9e8 + 5b1c88b
commit bb1ee87
Show file tree

Hide file tree

Showing 10 changed files with 8 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,7 @@
 
 - Change "Contact us" in the footer link examples to "Give us feedback" ([PR 972](https://github.com/nhsuk/nhsuk-frontend/pull/972))
 - Remove the pattern from the date input component
+- Adjust errorSummary bottom margin ([PR 973](https://github.com/nhsuk/nhsuk-frontend/pull/973))
 - Fix height of select component in Safari ([PR 987](https://github.com/nhsuk/nhsuk-frontend/pull/987))
 - Set minimum width of select component ([PR 987](https://github.com/nhsuk/nhsuk-frontend/pull/987))
 

diff --git a/packages/components/error-summary/_error-summary.scss b/packages/components/error-summary/_error-summary.scss
@@ -9,7 +9,13 @@
 
 .nhsuk-error-summary {
   @include nhsuk-responsive-padding(4);
-  @include nhsuk-responsive-margin(8, "bottom");
+
+  // Not using responsive spacing as we want smaller margin on mobile
+  margin-bottom: nhsuk-spacing(5);
+
+  @include govuk-media-query($from: tablet) {
+    margin-bottom: nhsuk-spacing(7);
+  }
 
   border: $nhsuk-border-width-mobile solid $nhsuk-error-color;
 

diff --git a/...-frontend_Error_summary_with_link_to_a_radio_field_0_document_0_iPhone_5_SE.png b/...-frontend_Error_summary_with_link_to_a_radio_field_0_document_0_iPhone_5_SE.png
diff --git a/...k-frontend_Error_summary_with_link_to_a_radio_field_0_document_1_iPhone_6-8.png b/...k-frontend_Error_summary_with_link_to_a_radio_field_0_document_1_iPhone_6-8.png
diff --git a/...e/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_2_iPad.png b/...e/nhsuk-frontend_Error_summary_with_link_to_a_radio_field_0_document_2_iPad.png
diff --git a/...tend_Error_summary_with_link_to_a_radio_field_0_document_3_Surface_iPad_Pro.png b/...tend_Error_summary_with_link_to_a_radio_field_0_document_3_Surface_iPad_Pro.png
diff --git a/...frontend_Error_summary_with_link_to_an_input_field_0_document_0_iPhone_5_SE.png b/...frontend_Error_summary_with_link_to_an_input_field_0_document_0_iPhone_5_SE.png
diff --git a/...-frontend_Error_summary_with_link_to_an_input_field_0_document_1_iPhone_6-8.png b/...-frontend_Error_summary_with_link_to_an_input_field_0_document_1_iPhone_6-8.png
diff --git a/.../nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_2_iPad.png b/.../nhsuk-frontend_Error_summary_with_link_to_an_input_field_0_document_2_iPad.png
diff --git a/...end_Error_summary_with_link_to_an_input_field_0_document_3_Surface_iPad_Pro.png b/...end_Error_summary_with_link_to_an_input_field_0_document_3_Surface_iPad_Pro.png