Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip plus tests on a fork #2784

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

sjberman
Copy link
Collaborator

Problem: The NGINX Plus JWT is only available on the upstream repo, so automated tests for Plus can't be run on forks.

Solution: Skip these test runs on a fork.

@github-actions github-actions bot added the chore Pull requests for routine tasks label Nov 19, 2024
@sjberman sjberman force-pushed the chore/plus-pipeline branch from 46ec3d8 to 74b0171 Compare November 19, 2024 21:07
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (581fd74) to head (0e682ff).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2784   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         107      107           
  Lines       10997    10997           
  Branches       50       50           
=======================================
  Hits         9883     9883           
  Misses       1054     1054           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sjberman sjberman force-pushed the chore/plus-pipeline branch 3 times, most recently from 32071bb to 436b079 Compare November 19, 2024 22:02
Problem: The NGINX Plus JWT is only available on the upstream repo, so automated tests for Plus can't be run on forks.

Solution: Skip these test runs on a fork.
@sjberman sjberman force-pushed the chore/plus-pipeline branch from 436b079 to 0e682ff Compare November 19, 2024 22:08
@sjberman sjberman marked this pull request as ready for review November 19, 2024 22:14
@sjberman sjberman requested a review from a team as a code owner November 19, 2024 22:14
@sjberman sjberman enabled auto-merge (squash) November 19, 2024 22:19
@sjberman sjberman merged commit 9fb7b33 into nginx:main Nov 20, 2024
40 checks passed
sjberman added a commit to sjberman/nginx-gateway-fabric that referenced this pull request Nov 25, 2024
Problem: The NGINX Plus JWT is only available on the upstream repo, so automated tests for Plus can't be run on forks.

Solution: Skip these test runs on a fork.
sjberman added a commit that referenced this pull request Nov 25, 2024
Problem: The NGINX Plus JWT is only available on the upstream repo, so automated tests for Plus can't be run on forks.

Solution: Skip these test runs on a fork.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants