-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add how-to for ClientSettingsPolicy #2071
Conversation
looks good to me
just max body size is 👍 |
I'm still working on the doc on policy merging and inheritance behavior (#1995), but this can be reviewed and merged separately, so marking as ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, made a bunch of suggestions to add a declarative, imperative tone.
We avoid passive voice where possible and don't want to be too familiar, which is why I got rid of all of the "We" and "Let's" I spotted.
eee56ff
to
d0604cc
Compare
@ADubhlaoich I re-requested your review because I added a couple callouts about a known limitation: d341771 |
df3b1cb
to
d341771
Compare
lgtm 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM still, small suggestion for phrasing the tracing note.
a32cf4b
to
0e6a6e2
Compare
Co-authored-by: Alan Dooley <[email protected]>
Co-authored-by: Alan Dooley <[email protected]>
0e6a6e2
to
6932923
Compare
Proposed changes
Problem: No user guide on how to use ClientSettingsPolicy.
Solution: Add a how-to guide that explains how to use ClientSettingsPolicy to configure client max body size.
Testing: Ran through steps and made sure they worked
Please focus on: Is it enough to show how to configure client max body size? Should we show off other client settings? Client max body size is the best demo end-to-end. We could set keepalive requests to 0 and show that the connection is not reused in the curl logs, but that isn't as impactful.
Closes #1763
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.