-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 config: add issue template config and bug report template #488
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for nextflow-training ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the idea of an issue template. I'm wondering however if this is maybe a little over-engineered, ie separating problem description / code / log output into separate fields might be a bit too rigid. If someone tried several different forms of the code, how/where would they put that? I would tend to favor having one big area for people to describe the problem, and maybe have the placeholder suggest the content/structure we need in order to troubleshoot (ie instructions to include any relevant code and log output).
Also feels like this is missing requesting the specific page URL with the instructions they were following when things went wrong.
attributes: | ||
label: Training materials version | ||
description: What's the git commit hash of the training materials you are using? | ||
placeholder: ex. [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems like the wrong kind of placeholder?
id: whats-wrong | ||
attributes: | ||
label: What's wrong? | ||
description: What's the problem in the training materials? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a bit redundant with the label, maybe state the purpose, ie are we looking for a high level summary here?
This adds an issue template chooser config (see docs along with a bug report issue template.
Together these will encourage folks learning Nextflow to get help in the correct location and ensure we have the info needed for looking into real bugs.
Might be worth adding a new content and/or improvement issue template as part of a separate PR. In the meantime, this config is set to allow blank issues that don't aren't one of the defined issue types (bug-report).