Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parameters to above profiles for correct handling of params #472

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

adamrtalbot
Copy link
Collaborator

Parameters were being read as defaults instead of the profile demo which was causing problems. This PR moves them to the right location.

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for nextflow-training ready!

Name Link
🔨 Latest commit b79be32
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-training/deploys/673e2abeb7c05800081748b7
😎 Deploy Preview https://deploy-preview-472--nextflow-training.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks uncontroversial to me

Copy link
Member

@kenibrewer kenibrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@kenibrewer kenibrewer merged commit 38d3263 into master Nov 20, 2024
8 checks passed
@kenibrewer kenibrewer deleted the params_in_wrong_locatiaon branch November 20, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants