Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Google Batch docs to clarify spot retry behaviour #5644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamrtalbot
Copy link
Collaborator

@adamrtalbot adamrtalbot commented Jan 6, 2025

I found the Google Batch spot documentation a bit hard to follow, I've updated the language here to see if it makes more sense.

@adamrtalbot adamrtalbot requested a review from a team as a code owner January 6, 2025 15:09
Copy link

netlify bot commented Jan 6, 2025

Deploy Preview for nextflow-docs-staging ready!

Name Link
🔨 Latest commit 66b0bf1
🔍 Latest deploy log https://app.netlify.com/sites/nextflow-docs-staging/deploys/677bf22d26f5700007463e96
😎 Deploy Preview https://deploy-preview-5644--nextflow-docs-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@bentsherman bentsherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually @pditommaso it looks like we aren't even using the auto-retry exit codes anymore. I think they were used here:

final error = lastEvent?.description
if( error && (EXIT_CODE_REGEX.matcher(error).find() || BATCH_ERROR_REGEX.matcher(error).find()) ) {
return new ProcessException(error)
}

But now there is just a regex matching all 500xx exit codes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants