-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize and align host monitoring config with newrelic-opentelemetry-examples #115
Optimize and align host monitoring config with newrelic-opentelemetry-examples #115
Conversation
I used this config and I saw some errors:
and metrics are not being sent. cc @josemore to be aware of this change |
some context / notes:
|
My understanding is that the answer of whether process metrics are enabled by default or not varies based on the install workflow. I used newrelic/nri-bundle, which I believe uses nri-kubernetes as a subchart, which I believe disables process metrics by default here. Let me know if I'm misunderstanding something. It seems like a pretty complex piece of config and not exactly clear to an outsider what does what.
Yup. |
This repo really needs a smoke test as part of the build 😉 |
Anything required to get this merged? It appears that snyk validation is failing due to an authentication error unrelated to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
c37868a
to
7247fb2
Compare
This repo has a merge requirement that all commits are signed, so I recommitted signed commits and force pushed. @rubenruizdegauna do you have merge permissions? |
Optimizations:
Separate cleanup including:
Corresponding synchronization PR in
newrelic-opentelemetry-examples
: newrelic/newrelic-opentelemetry-examples#636cc @alanwest