Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meter provider configurer to change observable up down counter to… #89

Merged
merged 4 commits into from
Feb 16, 2022

Conversation

jack-berg
Copy link
Contributor

… gauge

// data to still be useful when aggregation temporality is set to DELTA.
.registerView(
InstrumentSelector.builder()
.setInstrumentType(InstrumentType.OBSERVABLE_UP_DOWN_SUM)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to demonstrate changing the aggregation to last value for InstrumentType.UP_DOWN_COUNTER since those will be equally unusable as deltas.

... Also is it OBSERVABLE_UP_DOWN_SUM or OBSERVABLE_UP_DOWN_COUNTER?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last value doesn't help for sync up down counter because we would just get the last incremental recording. I.e. +1 or -1 or something liek that.

... Also is it OBSERVABLE_UP_DOWN_SUM or OBSERVABLE_UP_DOWN_COUNTER?

Its both. We recently deprecated OBSERVABLE_UP_DOWN_SUM in favor of OBSERVABLE_UP_DOWN_COUNTER

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last value doesn't help for sync up down counter because we would just get the last incremental recording. I.e. +1 or -1 or something liek that.

I promise, you'll only have to say this 16 more times.

@jack-berg jack-berg merged commit 1a3afa0 into main Feb 16, 2022
@jack-berg jack-berg deleted the customize-view-api branch February 16, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants