Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: config.yaml in docker collector example #640

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix: config.yaml in docker collector example #640

merged 2 commits into from
Aug 1, 2024

Conversation

harrykimpel
Copy link
Contributor

No description provided.

@harrykimpel harrykimpel requested a review from jcountsNR as a code owner July 9, 2024 09:47
@jack-berg
Copy link
Contributor

I don't believe this is necessary since ["env", "system" "gcp", "ec2", "azure"] and [env, system, gcp, ec2, azure] are equivalent YAML.

@harrykimpel
Copy link
Contributor Author

system, gcp,

I don't believe this is necessary since ["env", "system" "gcp", "ec2", "azure"] and [env, system, gcp, ec2, azure] are equivalent YAML.

the issue is that there is a comma missing between system and gcp

@jack-berg
Copy link
Contributor

the issue is that there is a comma missing between system and gcp

Got it! Thanks.

@jack-berg jack-berg merged commit 024f04b into newrelic:main Aug 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jack-berg jack-berg jack-berg approved these changes

@jcountsNR jcountsNR Awaiting requested review from jcountsNR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harrykimpel @jack-berg