Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alert_muting_rule): Add action_on_muting_rule_window_ended attribute in newrelic_alert_muting_rule Terraform Resource #1259

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

Aashirwadjain
Copy link
Collaborator

@Aashirwadjain Aashirwadjain commented Dec 16, 2024

Description

  • The addition of the action_on_muting_rule_window_ended attribute in the newrelic_alert_muting_rule Terraform resource aims to enhance the functionality of muting rules within New Relic's alerting system using terraform.
  • The attribute actionOnMutingRuleWindowEnded is added to MutingRule, MutingRuleCreateInput, and MutingRuleUpdateInput structs.
  • Link to GitHub Issue: https://github.com/newrelic/terraform-provider-newrelic/issues/2774

…rule create/update input

feat(alert-muting-rule): add actionOnMutingRuleWindowEnded to types.go and update muting rule test

fix(alert-muting-rule): fix unit test cases for alert muting rules
@Aashirwadjain Aashirwadjain force-pushed the muting-rule-end-behaviour branch from 9036b5a to 22dfc1b Compare December 17, 2024 12:08
Copy link
Contributor

@vagrawal-newrelic vagrawal-newrelic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@pranav-new-relic pranav-new-relic changed the title feat(alerts-muting-rule): Add end_behaviour attribute in newrelic_alert_muting_rule Terraform Resource feat(alert_muting_rule): Add end_behaviour attribute in newrelic_alert_muting_rule Terraform Resource Dec 18, 2024
Copy link
Member

@pranav-new-relic pranav-new-relic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work :)

@Aashirwadjain Aashirwadjain changed the title feat(alert_muting_rule): Add end_behaviour attribute in newrelic_alert_muting_rule Terraform Resource feat(alert_muting_rule): Add action_on_muting_rule_window_ended attribute in newrelic_alert_muting_rule Terraform Resource Jan 6, 2025
@vinay-newrelic vinay-newrelic merged commit 2a32988 into main Jan 8, 2025
11 of 12 checks passed
@vinay-newrelic vinay-newrelic deleted the muting-rule-end-behaviour branch January 8, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants