Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move DeleteTimelineFlow::prepare to separate function and use enum #10334

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

arpad-m
Copy link
Member

@arpad-m arpad-m commented Jan 9, 2025

It was requested by review in #10305 to use an enum or something like it for distinguishing the different modes instead of two parameters, because two flags allow four combinations, and two of them don't really make sense/ aren't used.

follow-up of #10305

@arpad-m arpad-m requested a review from problame January 9, 2025 23:36
@arpad-m arpad-m requested a review from a team as a code owner January 9, 2025 23:36
Copy link

github-actions bot commented Jan 10, 2025

7282 tests run: 6918 passed, 0 failed, 364 skipped (full report)


Flaky tests (4)

Postgres 17

Postgres 15

  • test_physical_replication_config_mismatch_max_locks_per_transaction: release-arm64

Postgres 14

Code coverage* (full report)

  • functions: 32.7% (8041 of 24618 functions)
  • lines: 47.8% (66807 of 139904 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
686d769 at 2025-01-10T17:24:50.406Z :recycle:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant