Update axum to 0.8.1 #10332
Update axum to 0.8.1 #10332
Conversation
| @@ -65,7 +65,7 @@ aws-smithy-types = "1.2" | |||
| aws-credential-types = "1.2.0" | |||
| aws-sigv4 = { version = "1.2", features = ["sign-http"] } | |||
| aws-types = "1.3" | |||
| axum = { version = "0.7.9", features = ["ws"] } | |||
| axum = { version = "0.8.1", features = ["ws"] } | |||
There was a problem hiding this comment.
What features does this add which we need, or how old is the old version, that we need to churn this dependency?
There was a problem hiding this comment.
Nothing that I'm aware of, but I also don't understand the problem with staying current. What consequences can you foresee?
There was a problem hiding this comment.
To answer the age question, see https://github.com/tokio-rs/axum/releases/tag/axum-v0.7.9, which says November 16th, 2024.
There was a problem hiding this comment.
No specific issues, it's just that I don't really like updating deps for the sake of updating them, as it adds churn to all developers' workflows.
My personal stance on this is that support, features, or bugs are all good reasons to move away from one version to the next, but if it ain't broken (and the repo version is only months old), why touch it?
There was a problem hiding this comment.
If we discover an issue with any upstream library and we report it, and we don't have the latest version, they might dismiss our report. I've seen that happen very often, even if the issue exists in the newest version.
It also rids us of one usage of async_trait, which is slower than the native async in trait support that has arrived a couple of months ago.
There was a problem hiding this comment.
I guess I tend to have the opposite opinion. If upstream isn't supporting a released version, then it is time to upgrade.
Anyway, gonna continue to hold this back given the tonic comments from Conrad. Might as well not compile 2 versions of axum.
Only a few things that needed updating: - async_trait was removed - Message::Text takes a Utf8Bytes object instead of a String Signed-off-by: Tristan Partin <[email protected]>
tristan957
force-pushed
the
tristan957/axum
branch
from
d4de344 to
299f52f
Compare
No tests were run or test report is not availableTest coverage report is not availableThe comment gets automatically updated with the latest test results
299f52f at 2025-01-09T22:24:21.623Z :recycle: |
This seems like a good reason to wait. I'll see if I can monitor that. |
Seems to be scheduled for the next release (0.13): |
|
Yeah, I just saw that |
|
Testing in #10348, that might not be a blocker. |
Only a few things that needed updating: