Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(pageserver): move queue logic to compaction.rs #10330

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Jan 9, 2025

Problem

close #10031, part of #9114

Summary of changes

Move the compaction job generation to compaction.rs, thus making the code more readable and debuggable. We now also return running job through the get compaction job API, versus before we only return scheduled jobs.

Copy link

github-actions bot commented Jan 9, 2025

7282 tests run: 6917 passed, 0 failed, 365 skipped (full report)


Code coverage* (full report)

  • functions: 32.6% (8041 of 24632 functions)
  • lines: 47.7% (66823 of 140018 lines)

* collected from Rust tests only


The comment gets automatically updated with the latest test results
07e6936 at 2025-01-10T20:16:37.370Z :recycle:

@skyzh skyzh force-pushed the skyzh/compaction-queue branch from 14770ae to e10d4da Compare January 9, 2025 20:24
skyzh added 3 commits January 9, 2025 17:11
Signed-off-by: Alex Chi Z <[email protected]>
Signed-off-by: Alex Chi Z <[email protected]>
@skyzh skyzh force-pushed the skyzh/compaction-queue branch from a5b3409 to e1da05b Compare January 9, 2025 22:12
pageserver/src/tenant/timeline/compaction.rs Outdated Show resolved Hide resolved
pageserver/src/tenant/timeline/compaction.rs Outdated Show resolved Hide resolved
@skyzh skyzh added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit b5d54ba Jan 10, 2025
84 checks passed
@skyzh skyzh deleted the skyzh/compaction-queue branch January 10, 2025 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gc_compaction: refactor CompationOptions <-> CompactionTask
2 participants