Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change on filter tooltip to avoid hide table data (Hotfix for #629) #712

Conversation

JonanOribe
Copy link
Contributor

Table's filter tooltip have been displaced on the top of table instead of over the first filtered result to allow users evaluate the result.

Before:

image

After:

image

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 1979 lines in your changes are missing coverage. Please review.

Comparison is base (f151d32) 46.28% compared to head (bdb478c) 38.72%.
Report is 29 commits behind head on develop.

Files Patch % Lines
...ons/advancedcharts/chart/gantt/frappe/lib/index.ts 0.43% 453 Missing ⚠️
...sions/advancedcharts/chart/gantt/frappe/lib/bar.ts 0.00% 194 Missing ⚠️
src/dashboard/sidebar/DashboardSidebar.tsx 13.11% 158 Missing and 1 partial ⚠️
...dvancedcharts/chart/gantt/frappe/lib/date_utils.js 6.08% 92 Missing and 16 partials ⚠️
...tensions/advancedcharts/chart/gantt/GanttChart.tsx 1.13% 87 Missing ⚠️
src/extensions/forms/chart/NeoForm.tsx 1.44% 68 Missing ⚠️
.../text2cypher/component/OverrideCardQueryEditor.tsx 4.22% 68 Missing ⚠️
src/dashboard/DashboardThunks.ts 12.69% 55 Missing ⚠️
...advancedcharts/chart/gantt/frappe/lib/svg_utils.ts 9.83% 55 Missing ⚠️
src/extensions/text2cypher/clients/ModelClient.ts 0.00% 54 Missing ⚠️
... and 68 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #712      +/-   ##
===========================================
- Coverage    46.28%   38.72%   -7.56%     
===========================================
  Files          166      203      +37     
  Lines         6594     8459    +1865     
  Branches      2043     2502     +459     
===========================================
+ Hits          3052     3276     +224     
- Misses        3501     5124    +1623     
- Partials        41       59      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alfredorubin96 alfredorubin96 merged commit 8ab4b56 into neo4j-labs:develop Nov 27, 2023
3 of 5 checks passed
@nielsdejong nielsdejong mentioned this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants