Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add GitHub workflow for unit testing and npm publish #17

Merged
merged 13 commits into from
Jun 10, 2022
Merged

add GitHub workflow for unit testing and npm publish #17

merged 13 commits into from
Jun 10, 2022

Conversation

wujjpp
Copy link
Collaborator

@wujjpp wujjpp commented Jun 9, 2022 •
edited
Loading

  1. add auto unit tesing for pushing
  2. add npm-publish workflow

@wujjpp
Copy link
Collaborator Author

wujjpp commented Jun 9, 2022 •
edited
Loading

@wey-gu

  1. auto unit tesing, https://github.com/wujjpp/nebula-node/runs/6814883959?check_suite_focus=true
  2. for publish to package repo #9 , please setup secrets.npm_token for this project

https://github.com/wujjpp/nebula-node/blob/enhance-ci/.github/workflows/npm-publish.yml#L59

@wujjpp wujjpp changed the title Add gitlab workflow add gitlab workflow Jun 9, 2022
@wujjpp wujjpp changed the title add gitlab workflow add gitlab workflow for unit testing and npm publish Jun 9, 2022
@wey-gu
Copy link
Member

wey-gu commented Jun 9, 2022

@wey-gu

  1. auto unit tesing, https://github.com/wujjpp/nebula-node/runs/6814883959?check_suite_focus=true
  2. for publish to package repo #9 , please setup secrets.npm_token for this project

https://github.com/wujjpp/nebula-node/blob/enhance-ci/.github/workflows/npm-publish.yml#L59

You are amazing @wujjpp
I will request the org admin to do it tomorrow.

@wey-gu wey-gu mentioned this pull request Jun 9, 2022
Closed
4 tasks
@wey-gu
Copy link
Member

wey-gu commented Jun 9, 2022

I guess you meant gh actions rather than gitlab 🙃

@wujjpp wujjpp changed the title add gitlab workflow for unit testing and npm publish add GitHub workflow for unit testing and npm publish Jun 9, 2022
@wujjpp
Copy link
Collaborator Author

wujjpp commented Jun 9, 2022

I guess you meant gh actions rather than gitlab 🙃

@wey-gu GitHub

@wey-gu
Copy link
Member

wey-gu commented Jun 10, 2022

@wujjpp a token should be set to npm_token already, I will merge the PR to see if it's properly set.

wey-gu
wey-gu approved these changes Jun 10, 2022
View reviewed changes
Copy link
Member

@wey-gu wey-gu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job, thanks!!!

@wey-gu wey-gu merged commit cec2574 into nebula-contrib:master Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wey-gu wey-gu wey-gu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wujjpp @wey-gu